From: Laszlo Ersek <lersek@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target
Date: Wed, 17 Jul 2013 12:24:48 +0200 [thread overview]
Message-ID: <51E670F0.7050703@redhat.com> (raw)
In-Reply-To: <1374055057-31988-1-git-send-email-famz@redhat.com>
On 07/17/13 11:57, Fam Zheng wrote:
> s->qcow and s->qcow_filename are allocated but not freed on error. Fix the
> possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of
> bdrv_create() and also the one of enable_write_target().
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>
> v2: Fix leak of s->qcow_filename, propagate returen value of
> enable_write_target(). [Laszlo]
>
> ---
> block/vvfat.c | 25 ++++++++++++++-----------
> 1 file changed, 14 insertions(+), 11 deletions(-)
Looks good to me.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2013-07-17 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 9:57 [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target Fam Zheng
2013-07-17 10:24 ` Laszlo Ersek [this message]
2013-07-18 5:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E670F0.7050703@redhat.com \
--to=lersek@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.