From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754620Ab3GQL6Y (ORCPT ); Wed, 17 Jul 2013 07:58:24 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:43252 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251Ab3GQL6W (ORCPT ); Wed, 17 Jul 2013 07:58:22 -0400 Message-ID: <51E686C1.8020801@ti.com> Date: Wed, 17 Jul 2013 14:57:53 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Grygorii Strashko CC: Tony Lindgren , Kevin Hilman , , , , , Linus Walleij , Stephen Warren Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> In-Reply-To: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grygorii, On 07/17/2013 02:41 PM, Grygorii Strashko wrote: > Hi Tony, Kevin > > This patch series introduces dynamic pinctrl handling in OMAP device framework > in the same way as it was before switching to DT. > This allow OMAP devices driver's developers to simply add dynamic pinctrl > handling for "default", "active", "idle", "sleep" PIN states in their drivers > by modifying DT definitions only - no modifications in drivers code are not needed. > Overall I like the idea but can we make a provision for device drivers to override this default pin state handling? The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states as it uses IO daisy chaining to implement wakeup. So depending on whether wakeup needs to be enabled or not I must be able to chose whether I put the pin in just "sleep" state or "sleep with wakeup" state. cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Date: Wed, 17 Jul 2013 14:57:53 +0300 Message-ID: <51E686C1.8020801@ti.com> References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Grygorii Strashko Cc: Kevin Hilman , Stephen Warren , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Linus Walleij , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi Grygorii, On 07/17/2013 02:41 PM, Grygorii Strashko wrote: > Hi Tony, Kevin > > This patch series introduces dynamic pinctrl handling in OMAP device framework > in the same way as it was before switching to DT. > This allow OMAP devices driver's developers to simply add dynamic pinctrl > handling for "default", "active", "idle", "sleep" PIN states in their drivers > by modifying DT definitions only - no modifications in drivers code are not needed. > Overall I like the idea but can we make a provision for device drivers to override this default pin state handling? The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states as it uses IO daisy chaining to implement wakeup. So depending on whether wakeup needs to be enabled or not I must be able to chose whether I put the pin in just "sleep" state or "sleep with wakeup" state. cheers, -roger From mboxrd@z Thu Jan 1 00:00:00 1970 From: rogerq@ti.com (Roger Quadros) Date: Wed, 17 Jul 2013 14:57:53 +0300 Subject: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling In-Reply-To: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> Message-ID: <51E686C1.8020801@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Grygorii, On 07/17/2013 02:41 PM, Grygorii Strashko wrote: > Hi Tony, Kevin > > This patch series introduces dynamic pinctrl handling in OMAP device framework > in the same way as it was before switching to DT. > This allow OMAP devices driver's developers to simply add dynamic pinctrl > handling for "default", "active", "idle", "sleep" PIN states in their drivers > by modifying DT definitions only - no modifications in drivers code are not needed. > Overall I like the idea but can we make a provision for device drivers to override this default pin state handling? The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states as it uses IO daisy chaining to implement wakeup. So depending on whether wakeup needs to be enabled or not I must be able to chose whether I put the pin in just "sleep" state or "sleep with wakeup" state. cheers, -roger