All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	Kevin Hilman <khilman@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree-discuss@lists.ozlabs.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling
Date: Wed, 17 Jul 2013 15:30:36 +0300	[thread overview]
Message-ID: <51E68E6C.60100@ti.com> (raw)
In-Reply-To: <51E686C1.8020801@ti.com>

On 07/17/2013 02:57 PM, Roger Quadros wrote:
> Hi Grygorii,
>
> On 07/17/2013 02:41 PM, Grygorii Strashko wrote:
>> Hi Tony, Kevin
>>
>> This patch series introduces dynamic pinctrl handling in OMAP device framework
>> in the same way as it was before switching to DT.
>> This allow OMAP devices driver's developers to simply add dynamic pinctrl
>> handling for "default", "active", "idle", "sleep" PIN states in their drivers
>> by modifying DT definitions only - no modifications in drivers code are not needed.
>>
>
> Overall I like the idea but can we make a provision for device drivers to override
> this default pin state handling?
>
> The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states
> as it uses IO daisy chaining to implement wakeup.
> So depending on whether wakeup needs to be enabled or not I must be able to chose whether
> I put the pin in just "sleep" state or "sleep with wakeup" state.

I think, in this case you can't use default behavior and need to define
custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not
define pins state with name "sleep', so Device core and OMAP device
framework will not touch your pins.

>
> cheers,
> -roger
>

Regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Kevin Hilman <khilman@linaro.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Tony Lindgren <tony@atomide.com>,
	devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling
Date: Wed, 17 Jul 2013 15:30:36 +0300	[thread overview]
Message-ID: <51E68E6C.60100@ti.com> (raw)
In-Reply-To: <51E686C1.8020801@ti.com>

On 07/17/2013 02:57 PM, Roger Quadros wrote:
> Hi Grygorii,
>
> On 07/17/2013 02:41 PM, Grygorii Strashko wrote:
>> Hi Tony, Kevin
>>
>> This patch series introduces dynamic pinctrl handling in OMAP device framework
>> in the same way as it was before switching to DT.
>> This allow OMAP devices driver's developers to simply add dynamic pinctrl
>> handling for "default", "active", "idle", "sleep" PIN states in their drivers
>> by modifying DT definitions only - no modifications in drivers code are not needed.
>>
>
> Overall I like the idea but can we make a provision for device drivers to override
> this default pin state handling?
>
> The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states
> as it uses IO daisy chaining to implement wakeup.
> So depending on whether wakeup needs to be enabled or not I must be able to chose whether
> I put the pin in just "sleep" state or "sleep with wakeup" state.

I think, in this case you can't use default behavior and need to define
custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not
define pins state with name "sleep', so Device core and OMAP device
framework will not touch your pins.

>
> cheers,
> -roger
>

Regards,
-grygorii

WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling
Date: Wed, 17 Jul 2013 15:30:36 +0300	[thread overview]
Message-ID: <51E68E6C.60100@ti.com> (raw)
In-Reply-To: <51E686C1.8020801@ti.com>

On 07/17/2013 02:57 PM, Roger Quadros wrote:
> Hi Grygorii,
>
> On 07/17/2013 02:41 PM, Grygorii Strashko wrote:
>> Hi Tony, Kevin
>>
>> This patch series introduces dynamic pinctrl handling in OMAP device framework
>> in the same way as it was before switching to DT.
>> This allow OMAP devices driver's developers to simply add dynamic pinctrl
>> handling for "default", "active", "idle", "sleep" PIN states in their drivers
>> by modifying DT definitions only - no modifications in drivers code are not needed.
>>
>
> Overall I like the idea but can we make a provision for device drivers to override
> this default pin state handling?
>
> The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states
> as it uses IO daisy chaining to implement wakeup.
> So depending on whether wakeup needs to be enabled or not I must be able to chose whether
> I put the pin in just "sleep" state or "sleep with wakeup" state.

I think, in this case you can't use default behavior and need to define
custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not
define pins state with name "sleep', so Device core and OMAP device
framework will not touch your pins.

>
> cheers,
> -roger
>

Regards,
-grygorii

  reply	other threads:[~2013-07-17 12:31 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 11:41 [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` Grygorii Strashko
2013-07-17 11:41 ` [PATCH 1/3] pinctrl: rollback check for !dev->pins in pinctrl_pm_select*() APIs Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 15:40   ` Tony Lindgren
2013-07-17 15:40     ` Tony Lindgren
2013-07-26 23:22     ` Linus Walleij
2013-07-26 23:22       ` Linus Walleij
2013-07-26 23:22       ` Linus Walleij
2013-07-17 11:41 ` [PATCH 2/3] ARM: OMAP2+: omap_device: add pinctrl handling Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 15:38   ` Tony Lindgren
2013-07-17 15:38     ` Tony Lindgren
2013-07-17 16:56     ` Grygorii Strashko
2013-07-17 16:56       ` Grygorii Strashko
2013-07-17 16:56       ` Grygorii Strashko
2013-07-18  8:14       ` Tony Lindgren
2013-07-18  8:14         ` Tony Lindgren
2013-07-18 11:22         ` Grygorii Strashko
2013-07-18 11:22           ` Grygorii Strashko
2013-07-18 11:22           ` Grygorii Strashko
2013-07-17 11:41 ` [PATCH 3/3] ARM: dts: omap4-sdp: add dynamic pin states for uart3/4 Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 11:41   ` Grygorii Strashko
2013-07-17 15:32   ` Tony Lindgren
2013-07-17 15:32     ` Tony Lindgren
2013-07-17 15:32     ` Tony Lindgren
2013-07-17 16:41     ` Grygorii Strashko
2013-07-17 16:41       ` Grygorii Strashko
2013-07-17 16:41       ` Grygorii Strashko
2013-07-18  8:09       ` Tony Lindgren
2013-07-18  8:09         ` Tony Lindgren
2013-07-18  8:09         ` Tony Lindgren
2013-07-18  8:54         ` Grygorii Strashko
2013-07-18  8:54           ` Grygorii Strashko
2013-07-18  8:54           ` Grygorii Strashko
2013-07-18  9:04           ` Tony Lindgren
2013-07-18  9:04             ` Tony Lindgren
2013-07-18 12:01             ` Grygorii Strashko
2013-07-18 12:01               ` Grygorii Strashko
2013-07-18 12:01               ` Grygorii Strashko
2013-07-17 11:57 ` [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Roger Quadros
2013-07-17 11:57   ` Roger Quadros
2013-07-17 11:57   ` Roger Quadros
2013-07-17 12:30   ` Grygorii Strashko [this message]
2013-07-17 12:30     ` Grygorii Strashko
2013-07-17 12:30     ` Grygorii Strashko
2013-07-18  6:44     ` Roger Quadros
2013-07-18  6:44       ` Roger Quadros
2013-07-18  6:44       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E68E6C.60100@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=khilman@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=swarren@wwwdotorg.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.