From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754733Ab3GQMb6 (ORCPT ); Wed, 17 Jul 2013 08:31:58 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:59500 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754152Ab3GQMb4 (ORCPT ); Wed, 17 Jul 2013 08:31:56 -0400 Message-ID: <51E68E6C.60100@ti.com> Date: Wed, 17 Jul 2013 15:30:36 +0300 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Roger Quadros CC: Tony Lindgren , Kevin Hilman , , , , , Linus Walleij , Stephen Warren Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> <51E686C1.8020801@ti.com> In-Reply-To: <51E686C1.8020801@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/17/2013 02:57 PM, Roger Quadros wrote: > Hi Grygorii, > > On 07/17/2013 02:41 PM, Grygorii Strashko wrote: >> Hi Tony, Kevin >> >> This patch series introduces dynamic pinctrl handling in OMAP device framework >> in the same way as it was before switching to DT. >> This allow OMAP devices driver's developers to simply add dynamic pinctrl >> handling for "default", "active", "idle", "sleep" PIN states in their drivers >> by modifying DT definitions only - no modifications in drivers code are not needed. >> > > Overall I like the idea but can we make a provision for device drivers to override > this default pin state handling? > > The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states > as it uses IO daisy chaining to implement wakeup. > So depending on whether wakeup needs to be enabled or not I must be able to chose whether > I put the pin in just "sleep" state or "sleep with wakeup" state. I think, in this case you can't use default behavior and need to define custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not define pins state with name "sleep', so Device core and OMAP device framework will not touch your pins. > > cheers, > -roger > Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling Date: Wed, 17 Jul 2013 15:30:36 +0300 Message-ID: <51E68E6C.60100@ti.com> References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> <51E686C1.8020801@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51E686C1.8020801@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Roger Quadros Cc: Kevin Hilman , Stephen Warren , Tony Lindgren , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Linus Walleij , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 07/17/2013 02:57 PM, Roger Quadros wrote: > Hi Grygorii, > > On 07/17/2013 02:41 PM, Grygorii Strashko wrote: >> Hi Tony, Kevin >> >> This patch series introduces dynamic pinctrl handling in OMAP device framework >> in the same way as it was before switching to DT. >> This allow OMAP devices driver's developers to simply add dynamic pinctrl >> handling for "default", "active", "idle", "sleep" PIN states in their drivers >> by modifying DT definitions only - no modifications in drivers code are not needed. >> > > Overall I like the idea but can we make a provision for device drivers to override > this default pin state handling? > > The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states > as it uses IO daisy chaining to implement wakeup. > So depending on whether wakeup needs to be enabled or not I must be able to chose whether > I put the pin in just "sleep" state or "sleep with wakeup" state. I think, in this case you can't use default behavior and need to define custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not define pins state with name "sleep', so Device core and OMAP device framework will not touch your pins. > > cheers, > -roger > Regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: grygorii.strashko@ti.com (Grygorii Strashko) Date: Wed, 17 Jul 2013 15:30:36 +0300 Subject: [PATCH 0/3] ARM: OMAP2+: omap_device: add dynamic pinctrl handling In-Reply-To: <51E686C1.8020801@ti.com> References: <1374061312-25469-1-git-send-email-grygorii.strashko@ti.com> <51E686C1.8020801@ti.com> Message-ID: <51E68E6C.60100@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/17/2013 02:57 PM, Roger Quadros wrote: > Hi Grygorii, > > On 07/17/2013 02:41 PM, Grygorii Strashko wrote: >> Hi Tony, Kevin >> >> This patch series introduces dynamic pinctrl handling in OMAP device framework >> in the same way as it was before switching to DT. >> This allow OMAP devices driver's developers to simply add dynamic pinctrl >> handling for "default", "active", "idle", "sleep" PIN states in their drivers >> by modifying DT definitions only - no modifications in drivers code are not needed. >> > > Overall I like the idea but can we make a provision for device drivers to override > this default pin state handling? > > The OMAP EHCI driver is one such special case where the wakeup mechanism is tied to pinctrl states > as it uses IO daisy chaining to implement wakeup. > So depending on whether wakeup needs to be enabled or not I must be able to chose whether > I put the pin in just "sleep" state or "sleep with wakeup" state. I think, in this case you can't use default behavior and need to define custom pins states like "sleep_wakeup"/"sleep_no_wakeup" and do not define pins state with name "sleep', so Device core and OMAP device framework will not touch your pins. > > cheers, > -roger > Regards, -grygorii