From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] xen: allow architecture to choose whether to compress installed xen binary Date: Wed, 17 Jul 2013 12:31:40 +0100 Message-ID: <51E69CBC02000078000E595F@nat28.tlf.novell.com> References: <1373630398-20993-1-git-send-email-ijc@hellion.org.uk> <1373877510-18967-1-git-send-email-ijc@hellion.org.uk> <51E3E0B302000078000E4DEA@nat28.tlf.novell.com> <1373966142.4663.17.camel@kazak.uk.xensource.com> <51E52C9202000078000E5405@nat28.tlf.novell.com> <1374059599.8960.32.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1374059599.8960.32.camel@kazak.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: julien.grall@citrix.com, tim@xen.org, xen-devel@lists.xen.org, keir@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 17.07.13 at 13:13, Ian Campbell wrote: > On Tue, 2013-07-16 at 10:20 +0100, Jan Beulich wrote: > In the end I thought CONFIG_XEN_INSTALL_SUFFIX was more natural, here it > is. Ah, here it comes (out of order with the other one for some reason). > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -28,16 +28,19 @@ else > echo "*** Xen x86/32 target no longer supported!" > endif > > +# Define as an alias to avoid amazingly long lines > +Z := $(CONFIG_XEN_INSTALL_SUFFIX) I'd prefer this to be limited in scope to _install and _uninstall (just like T and D get set for _uninstall [but for an unknown reason the same isn't being done for _install - perhaps that's something you could clean up as you go without risking any breakage]): > @@ -56,10 +59,10 @@ _install: $(TARGET).gz > _uninstall: D=$(DESTDIR) > _uninstall: T=$(notdir $(TARGET)) Jan