All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Dmitry Kravkov <dmitry@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net v2 5/6] bnx2x: fix PTE write access error
Date: Thu, 18 Jul 2013 01:51:37 +0400	[thread overview]
Message-ID: <51E711E9.7030500@cogentembedded.com> (raw)
In-Reply-To: <1374097512-19540-6-git-send-email-dmitry@broadcom.com>

Hello.

On 07/18/2013 01:45 AM, Dmitry Kravkov wrote:

> From: Barak Witkowsky <barak@broadcom.com>

> PTE write access error  might occur in MF_ALLOWED mode when IOMMU
> is active. The patch adds rmmod HSI indicating to MFW to stop
> running queries which might trigger this failure.

> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>

    Not signed off by the author?

> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> index 0f3de02..9394b7d 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

> @@ -12824,6 +12828,11 @@ static void __bnx2x_remove(struct pci_dev *pdev,
>   	bnx2x_dcbnl_update_applist(bp, true);
>   #endif
>
> +	if ((IS_PF(bp)) &&

    () not needed.

> +	    (!BP_NOMCP(bp)) &&

    Likewise.

> +	    (bp->flags & BC_SUPPORTS_RMMOD_CMD))
> +		bnx2x_fw_command(bp, DRV_MSG_CODE_RMMOD, 0);
> +

WBR, Sergei

  reply	other threads:[~2013-07-17 21:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-17 21:45 [PATCH net v2 0/6] bnx2x: fixes Dmitry Kravkov
2013-07-17 21:45 ` [PATCH net v2 1/6] bnx2x: properly initialize statistic counters Dmitry Kravkov
2013-07-17 21:45 ` [PATCH net v2 2/6] bnx2x: prevent statistics update flow to act before statistics are started Dmitry Kravkov
2013-07-17 21:45 ` [PATCH net v2 3/6] bnx2x: update fairness parameters following DCB negotiation Dmitry Kravkov
2013-07-17 21:45 ` [PATCH net v2 4/6] bnx2x: fix memory leak in VF Dmitry Kravkov
2013-07-17 21:45 ` [PATCH net v2 5/6] bnx2x: fix PTE write access error Dmitry Kravkov
2013-07-17 21:51   ` Sergei Shtylyov [this message]
2013-07-17 21:45 ` [PATCH net v2 6/6] bnx2x: prevent crash in shutdown flow with CNIC Dmitry Kravkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E711E9.7030500@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=dmitry@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.