From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UzjVx-0007PN-92 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 04:24:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UzjVp-00006U-2f for qemu-devel@nongnu.org; Thu, 18 Jul 2013 04:24:41 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:53127 helo=mx01.kamp.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1UzjVo-00006N-OZ for qemu-devel@nongnu.org; Thu, 18 Jul 2013 04:24:33 -0400 Message-ID: <51E7A642.5080904@kamp.de> Date: Thu, 18 Jul 2013 10:24:34 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1373544987-20613-1-git-send-email-pl@kamp.de> <51E6B2CF.2020603@redhat.com> In-Reply-To: <51E6B2CF.2020603@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com On 17.07.2013 17:05, Paolo Bonzini wrote: > Il 11/07/2013 14:16, Peter Lieven ha scritto: >> this series adds logical block provisioning functions to the iscsi layer. >> it also is the first step to the change of migration to coroutines in >> block/iscsi. >> >> the changes to qemu-img and block migration have been split and will >> follow in separte patches later. >> >> changes in v3: >> - merge both block provision inquiries into one patch. explitely free the iscsi tasks after >> the inquiry. limit the unmap to 128k blocks if the target returns max_unmap = 0xffffffff; >> - in the coroutine framework free the scsi task in the caller not in the callback. also >> change the iTask init as Kevin suggested. >> - in iscsi_co_is_allocated() return unallocated only for ANCHORED and UNALLOACTED to avoid >> a wrong return value if a new provisioning status is introduced. >> - added new patch adding .bdrv_co_discard >> - build .bdrv_co_write_zeroes on top of .bdrv_co_discard >> - fixed a bug for -ENOSPC in iscsi_create() spotted by Kevin. >> - remove support for misaligned nb_sectors in aio_readv >> - add log message in error case to lun alignment checks >> >> Peter Lieven (10): >> iscsi: add logical block provisioning information to iscsilun >> iscsi: add .bdrv_co_is_allocated >> iscsi: add .bdrv_co_discard >> iscsi: add .bdrv_write_zeroes >> block: add bdrv_write_zeroes() >> block/raw: add bdrv_co_write_zeroes >> iscsi: fix -ENOSPC in iscsi_create() >> iscsi: factor out sector conversions >> iscsi: remove support for misaligned nb_sectors in aio_readv >> iscsi: assert that sectors are aligned to LUN blocksize >> >> block.c | 27 ++- >> block/iscsi.c | 433 +++++++++++++++++++++++++++++++++++++------------ >> block/raw.c | 8 + >> include/block/block.h | 2 + >> 4 files changed, 358 insertions(+), 112 deletions(-) >> > Applied 7-10 to scsi-next, please rebase/resubmit the others (possibly > together with the qemu-img convert patches). please consider also pulling [PATCHv4 1/2] iscsi: add logical block provisioning information to iscsilun [PATCHv4 2/2] iscsi: add .bdrv_co_is_allocated these patches are unproblematic and keep the number of patches in the series for the general qemu-img convert/write_zeroes_w_discard approach smaller. patch 2/2 can also be easily converted to get_block_status even with correct BDRV_BLOCK_ZERO information by evaluating iscsilun->lbprz (which is added in patch 1). Peter