From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: RFC: removing hardcoded "modprobe blktap" in xencommons Date: Thu, 18 Jul 2013 09:43:17 +0100 Message-ID: <51E7AAA5.7090803@eu.citrix.com> References: <20130712161255.GB4409@zion.uk.xensource.com> <51E3AD9C02000078000E4C9D@nat28.tlf.novell.com> <20130715073309.GA25286@zion.uk.xensource.com> <51E3C49502000078000E4D3D@nat28.tlf.novell.com> <20130715082656.GC25286@zion.uk.xensource.com> <51E3DE2A02000078000E4DCC@nat28.tlf.novell.com> <20130715093845.GA28802@zion.uk.xensource.com> <51E40240.5010108@eu.citrix.com> <20966.31985.748264.709101@mariner.uk.xensource.com> <20130718073127.GA26530@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130718073127.GA26530@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 07/18/2013 08:31 AM, Wei Liu wrote: > On Wed, Jul 17, 2013 at 12:16:01PM +0100, Ian Jackson wrote: >> George Dunlap writes ("Re: RFC: removing hardcoded "modprobe blktap" in xencommons"): >>> If we did something like this, we'd still have to have the modprobes in >>> xencommons for older kernels; we'd just have to have a way to disable it >>> for newer kernels. >> >> Many of the modules we'd be asking for (eg blktap*) don't exist on >> newer kernels at all, so the modprobe is harmless. >> >> For the others we can check uname. >> > > I think Jan's main point is "defer loading modules till the last > minute". Checking for uname in xencommons cannot achieve that. It can defer modules *for systems that can load them automatically*, while loading them immediately for those that don't. I think that's an improvement. -George