From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757926Ab3GRJBp (ORCPT ); Thu, 18 Jul 2013 05:01:45 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:55025 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757022Ab3GRJBl (ORCPT ); Thu, 18 Jul 2013 05:01:41 -0400 Message-ID: <51E7AECA.1000204@ti.com> Date: Thu, 18 Jul 2013 14:30:58 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Greg KH CC: , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-3-git-send-email-kishon@ti.com> <20130718072149.GB16720@kroah.com> In-Reply-To: <20130718072149.GB16720@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> >> However using the old USB PHY library cannot be completely removed >> because OTG is intertwined with PHY and moving to the new framework >> will break OTG. Once we have a separate OTG state machine, we >> can get rid of the USB PHY library. >> >> Signed-off-by: Kishon Vijay Abraham I >> Reviewed-by: Sylwester Nawrocki >> Acked-by: Felipe Balbi >> --- >> drivers/usb/phy/Kconfig | 1 + >> drivers/usb/phy/phy-omap-usb2.c | 45 +++++++++++++++++++++++++++++++++++---- >> 2 files changed, 42 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig >> index 3622fff..cc55993 100644 >> --- a/drivers/usb/phy/Kconfig >> +++ b/drivers/usb/phy/Kconfig >> @@ -75,6 +75,7 @@ config OMAP_CONTROL_USB >> config OMAP_USB2 >> tristate "OMAP USB2 PHY Driver" >> depends on ARCH_OMAP2PLUS >> + depends on GENERIC_PHY >> select OMAP_CONTROL_USB >> help >> Enable this to support the transceiver that is part of SOC. This >> diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c >> index 844ab68..751b30f 100644 >> --- a/drivers/usb/phy/phy-omap-usb2.c >> +++ b/drivers/usb/phy/phy-omap-usb2.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * omap_usb2_set_comparator - links the comparator present in the sytem with >> @@ -119,10 +120,36 @@ static int omap_usb2_suspend(struct usb_phy *x, int suspend) >> return 0; >> } >> >> +static int omap_usb_power_off(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 0); >> + >> + return 0; >> +} >> + >> +static int omap_usb_power_on(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 1); >> + >> + return 0; >> +} >> + >> +static struct phy_ops ops = { >> + .power_on = omap_usb_power_on, >> + .power_off = omap_usb_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> static int omap_usb2_probe(struct platform_device *pdev) >> { >> struct omap_usb *phy; >> + struct phy *generic_phy; >> struct usb_otg *otg; >> + struct phy_provider *phy_provider; >> >> phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); >> if (!phy) { >> @@ -144,6 +171,11 @@ static int omap_usb2_probe(struct platform_device *pdev) >> phy->phy.otg = otg; >> phy->phy.type = USB_PHY_TYPE_USB2; >> >> + phy_provider = devm_of_phy_provider_register(phy->dev, >> + of_phy_simple_xlate); >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> phy->control_dev = omap_get_control_dev(); >> if (IS_ERR(phy->control_dev)) { >> dev_dbg(&pdev->dev, "Failed to get control device\n"); >> @@ -159,6 +191,15 @@ static int omap_usb2_probe(struct platform_device *pdev) >> otg->start_srp = omap_usb_start_srp; >> otg->phy = &phy->phy; >> >> + platform_set_drvdata(pdev, phy); >> + pm_runtime_enable(phy->dev); >> + >> + generic_phy = devm_phy_create(phy->dev, 0, &ops, "omap-usb2"); >> + if (IS_ERR(generic_phy)) >> + return PTR_ERR(generic_phy); > > So, if I have two of these controllers in my system, I can't create the > second phy because the name for it will be identical to the first? > That's why the phy core should handle the id, and not rely on the > drivers to set it, as they have no idea how many they have in the > system. hmm.. for such cases I'll have something like PLATFORM_DEVID_AUTO. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework Date: Thu, 18 Jul 2013 14:30:58 +0530 Message-ID: <51E7AECA.1000204@ti.com> References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-3-git-send-email-kishon@ti.com> <20130718072149.GB16720@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130718072149.GB16720-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Greg KH Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, george.cherian-l0cyMroinI0@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, balajitk-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org List-Id: devicetree@vger.kernel.org On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> >> However using the old USB PHY library cannot be completely removed >> because OTG is intertwined with PHY and moving to the new framework >> will break OTG. Once we have a separate OTG state machine, we >> can get rid of the USB PHY library. >> >> Signed-off-by: Kishon Vijay Abraham I >> Reviewed-by: Sylwester Nawrocki >> Acked-by: Felipe Balbi >> --- >> drivers/usb/phy/Kconfig | 1 + >> drivers/usb/phy/phy-omap-usb2.c | 45 +++++++++++++++++++++++++++++++++++---- >> 2 files changed, 42 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig >> index 3622fff..cc55993 100644 >> --- a/drivers/usb/phy/Kconfig >> +++ b/drivers/usb/phy/Kconfig >> @@ -75,6 +75,7 @@ config OMAP_CONTROL_USB >> config OMAP_USB2 >> tristate "OMAP USB2 PHY Driver" >> depends on ARCH_OMAP2PLUS >> + depends on GENERIC_PHY >> select OMAP_CONTROL_USB >> help >> Enable this to support the transceiver that is part of SOC. This >> diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c >> index 844ab68..751b30f 100644 >> --- a/drivers/usb/phy/phy-omap-usb2.c >> +++ b/drivers/usb/phy/phy-omap-usb2.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * omap_usb2_set_comparator - links the comparator present in the sytem with >> @@ -119,10 +120,36 @@ static int omap_usb2_suspend(struct usb_phy *x, int suspend) >> return 0; >> } >> >> +static int omap_usb_power_off(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 0); >> + >> + return 0; >> +} >> + >> +static int omap_usb_power_on(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 1); >> + >> + return 0; >> +} >> + >> +static struct phy_ops ops = { >> + .power_on = omap_usb_power_on, >> + .power_off = omap_usb_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> static int omap_usb2_probe(struct platform_device *pdev) >> { >> struct omap_usb *phy; >> + struct phy *generic_phy; >> struct usb_otg *otg; >> + struct phy_provider *phy_provider; >> >> phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); >> if (!phy) { >> @@ -144,6 +171,11 @@ static int omap_usb2_probe(struct platform_device *pdev) >> phy->phy.otg = otg; >> phy->phy.type = USB_PHY_TYPE_USB2; >> >> + phy_provider = devm_of_phy_provider_register(phy->dev, >> + of_phy_simple_xlate); >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> phy->control_dev = omap_get_control_dev(); >> if (IS_ERR(phy->control_dev)) { >> dev_dbg(&pdev->dev, "Failed to get control device\n"); >> @@ -159,6 +191,15 @@ static int omap_usb2_probe(struct platform_device *pdev) >> otg->start_srp = omap_usb_start_srp; >> otg->phy = &phy->phy; >> >> + platform_set_drvdata(pdev, phy); >> + pm_runtime_enable(phy->dev); >> + >> + generic_phy = devm_phy_create(phy->dev, 0, &ops, "omap-usb2"); >> + if (IS_ERR(generic_phy)) >> + return PTR_ERR(generic_phy); > > So, if I have two of these controllers in my system, I can't create the > second phy because the name for it will be identical to the first? > That's why the phy core should handle the id, and not rely on the > drivers to set it, as they have no idea how many they have in the > system. hmm.. for such cases I'll have something like PLATFORM_DEVID_AUTO. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Date: Thu, 18 Jul 2013 09:12:58 +0000 Subject: Re: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework Message-Id: <51E7AECA.1000204@ti.com> List-Id: References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-3-git-send-email-kishon@ti.com> <20130718072149.GB16720@kroah.com> In-Reply-To: <20130718072149.GB16720@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> >> However using the old USB PHY library cannot be completely removed >> because OTG is intertwined with PHY and moving to the new framework >> will break OTG. Once we have a separate OTG state machine, we >> can get rid of the USB PHY library. >> >> Signed-off-by: Kishon Vijay Abraham I >> Reviewed-by: Sylwester Nawrocki >> Acked-by: Felipe Balbi >> --- >> drivers/usb/phy/Kconfig | 1 + >> drivers/usb/phy/phy-omap-usb2.c | 45 +++++++++++++++++++++++++++++++++++---- >> 2 files changed, 42 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig >> index 3622fff..cc55993 100644 >> --- a/drivers/usb/phy/Kconfig >> +++ b/drivers/usb/phy/Kconfig >> @@ -75,6 +75,7 @@ config OMAP_CONTROL_USB >> config OMAP_USB2 >> tristate "OMAP USB2 PHY Driver" >> depends on ARCH_OMAP2PLUS >> + depends on GENERIC_PHY >> select OMAP_CONTROL_USB >> help >> Enable this to support the transceiver that is part of SOC. This >> diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c >> index 844ab68..751b30f 100644 >> --- a/drivers/usb/phy/phy-omap-usb2.c >> +++ b/drivers/usb/phy/phy-omap-usb2.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * omap_usb2_set_comparator - links the comparator present in the sytem with >> @@ -119,10 +120,36 @@ static int omap_usb2_suspend(struct usb_phy *x, int suspend) >> return 0; >> } >> >> +static int omap_usb_power_off(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 0); >> + >> + return 0; >> +} >> + >> +static int omap_usb_power_on(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 1); >> + >> + return 0; >> +} >> + >> +static struct phy_ops ops = { >> + .power_on = omap_usb_power_on, >> + .power_off = omap_usb_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> static int omap_usb2_probe(struct platform_device *pdev) >> { >> struct omap_usb *phy; >> + struct phy *generic_phy; >> struct usb_otg *otg; >> + struct phy_provider *phy_provider; >> >> phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); >> if (!phy) { >> @@ -144,6 +171,11 @@ static int omap_usb2_probe(struct platform_device *pdev) >> phy->phy.otg = otg; >> phy->phy.type = USB_PHY_TYPE_USB2; >> >> + phy_provider = devm_of_phy_provider_register(phy->dev, >> + of_phy_simple_xlate); >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> phy->control_dev = omap_get_control_dev(); >> if (IS_ERR(phy->control_dev)) { >> dev_dbg(&pdev->dev, "Failed to get control device\n"); >> @@ -159,6 +191,15 @@ static int omap_usb2_probe(struct platform_device *pdev) >> otg->start_srp = omap_usb_start_srp; >> otg->phy = &phy->phy; >> >> + platform_set_drvdata(pdev, phy); >> + pm_runtime_enable(phy->dev); >> + >> + generic_phy = devm_phy_create(phy->dev, 0, &ops, "omap-usb2"); >> + if (IS_ERR(generic_phy)) >> + return PTR_ERR(generic_phy); > > So, if I have two of these controllers in my system, I can't create the > second phy because the name for it will be identical to the first? > That's why the phy core should handle the id, and not rely on the > drivers to set it, as they have no idea how many they have in the > system. hmm.. for such cases I'll have something like PLATFORM_DEVID_AUTO. Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 From: kishon@ti.com (Kishon Vijay Abraham I) Date: Thu, 18 Jul 2013 14:30:58 +0530 Subject: [PATCH 02/15] usb: phy: omap-usb2: use the new generic PHY framework In-Reply-To: <20130718072149.GB16720@kroah.com> References: <1374129984-765-1-git-send-email-kishon@ti.com> <1374129984-765-3-git-send-email-kishon@ti.com> <20130718072149.GB16720@kroah.com> Message-ID: <51E7AECA.1000204@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 18 July 2013 12:51 PM, Greg KH wrote: > On Thu, Jul 18, 2013 at 12:16:11PM +0530, Kishon Vijay Abraham I wrote: >> Used the generic PHY framework API to create the PHY. Now the power off and >> power on are done in omap_usb_power_off and omap_usb_power_on respectively. >> >> However using the old USB PHY library cannot be completely removed >> because OTG is intertwined with PHY and moving to the new framework >> will break OTG. Once we have a separate OTG state machine, we >> can get rid of the USB PHY library. >> >> Signed-off-by: Kishon Vijay Abraham I >> Reviewed-by: Sylwester Nawrocki >> Acked-by: Felipe Balbi >> --- >> drivers/usb/phy/Kconfig | 1 + >> drivers/usb/phy/phy-omap-usb2.c | 45 +++++++++++++++++++++++++++++++++++---- >> 2 files changed, 42 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig >> index 3622fff..cc55993 100644 >> --- a/drivers/usb/phy/Kconfig >> +++ b/drivers/usb/phy/Kconfig >> @@ -75,6 +75,7 @@ config OMAP_CONTROL_USB >> config OMAP_USB2 >> tristate "OMAP USB2 PHY Driver" >> depends on ARCH_OMAP2PLUS >> + depends on GENERIC_PHY >> select OMAP_CONTROL_USB >> help >> Enable this to support the transceiver that is part of SOC. This >> diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers/usb/phy/phy-omap-usb2.c >> index 844ab68..751b30f 100644 >> --- a/drivers/usb/phy/phy-omap-usb2.c >> +++ b/drivers/usb/phy/phy-omap-usb2.c >> @@ -28,6 +28,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * omap_usb2_set_comparator - links the comparator present in the sytem with >> @@ -119,10 +120,36 @@ static int omap_usb2_suspend(struct usb_phy *x, int suspend) >> return 0; >> } >> >> +static int omap_usb_power_off(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 0); >> + >> + return 0; >> +} >> + >> +static int omap_usb_power_on(struct phy *x) >> +{ >> + struct omap_usb *phy = phy_get_drvdata(x); >> + >> + omap_control_usb_phy_power(phy->control_dev, 1); >> + >> + return 0; >> +} >> + >> +static struct phy_ops ops = { >> + .power_on = omap_usb_power_on, >> + .power_off = omap_usb_power_off, >> + .owner = THIS_MODULE, >> +}; >> + >> static int omap_usb2_probe(struct platform_device *pdev) >> { >> struct omap_usb *phy; >> + struct phy *generic_phy; >> struct usb_otg *otg; >> + struct phy_provider *phy_provider; >> >> phy = devm_kzalloc(&pdev->dev, sizeof(*phy), GFP_KERNEL); >> if (!phy) { >> @@ -144,6 +171,11 @@ static int omap_usb2_probe(struct platform_device *pdev) >> phy->phy.otg = otg; >> phy->phy.type = USB_PHY_TYPE_USB2; >> >> + phy_provider = devm_of_phy_provider_register(phy->dev, >> + of_phy_simple_xlate); >> + if (IS_ERR(phy_provider)) >> + return PTR_ERR(phy_provider); >> + >> phy->control_dev = omap_get_control_dev(); >> if (IS_ERR(phy->control_dev)) { >> dev_dbg(&pdev->dev, "Failed to get control device\n"); >> @@ -159,6 +191,15 @@ static int omap_usb2_probe(struct platform_device *pdev) >> otg->start_srp = omap_usb_start_srp; >> otg->phy = &phy->phy; >> >> + platform_set_drvdata(pdev, phy); >> + pm_runtime_enable(phy->dev); >> + >> + generic_phy = devm_phy_create(phy->dev, 0, &ops, "omap-usb2"); >> + if (IS_ERR(generic_phy)) >> + return PTR_ERR(generic_phy); > > So, if I have two of these controllers in my system, I can't create the > second phy because the name for it will be identical to the first? > That's why the phy core should handle the id, and not rely on the > drivers to set it, as they have no idea how many they have in the > system. hmm.. for such cases I'll have something like PLATFORM_DEVID_AUTO. Thanks Kishon