From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 1/3] xen: allow architecture to choose
 how/whether to compress installed xen binary
Date: Thu, 18 Jul 2013 08:34:46 +0100
Message-ID: <51E7B6B602000078000E5D36@nat28.tlf.novell.com>
References: <1374075441.26728.14.camel@kazak.uk.xensource.com>
	<1374075473-32502-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <JBeulich@suse.com>) id 1Uzijo-0002ec-7x
	for xen-devel@lists.xenproject.org; Thu, 18 Jul 2013 07:34:56 +0000
In-Reply-To: <1374075473-32502-1-git-send-email-ian.campbell@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: julien.grall@citrix.com, xen-devel <xen-devel@lists.xenproject.org>, tim@xen.org, keir@xen.org, stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

>>> On 17.07.13 at 17:37, Ian Campbell <ian.campbell@citrix.com> wrote:
> @@ -53,13 +55,14 @@ _install: $(TARGET).gz
>  	fi
>  
>  .PHONY: _uninstall
> +_uninstall: Z=$(CONFIG_XEN_INSTALL_SUFFIX)
>  _uninstall: D=$(DESTDIR)
>  _uninstall: T=$(notdir $(TARGET))

As you will likely want to rev this series once more anyway after my
comment on patch 3, would you mind doing the above in (at the
same time, as it turns out) logical (path, name, extension) and
alphabetical order?

Jan

>  _uninstall:
> -	rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION).gz
> -	rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).gz
> -	rm -f $(D)/boot/$(T)-$(XEN_VERSION).gz
> -	rm -f $(D)/boot/$(T).gz
> +	rm -f $(D)/boot/$(T)-$(XEN_FULLVERSION)$(Z)
> +	rm -f $(D)/boot/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> +	rm -f $(D)/boot/$(T)-$(XEN_VERSION)$(Z)
> +	rm -f $(D)/boot/$(T)$(Z)
>  	rm -f $(D)/boot/$(T)-syms-$(XEN_FULLVERSION)
>  	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi
>  	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi
> -- 
> 1.7.2.5