All of lore.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
	Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Re: [RFC PATCH 3/4] tracing: Kill tracing_open/release_generic_file
Date: Thu, 18 Jul 2013 19:56:35 +0900	[thread overview]
Message-ID: <51E7C9E3.1070506@hitachi.com> (raw)
In-Reply-To: <20130717191917.GA14137@redhat.com>

(2013/07/18 4:19), Oleg Nesterov wrote:
> On 07/16, Steven Rostedt wrote:
>>
>> On Tue, 2013-07-16 at 20:57 +0200, Oleg Nesterov wrote:
>>> trace_array_get() goes away. NOTE! this is actually wrong until we
>>> change instance_delete() path to nullify ->i_private.
>>
>> I think this needs to be done first.
> 
> Do you mean "change instance_delete() path to nullify ->i_private" ?
> 
> Yes. Well yes and no, afaics, but please ignore. Of course, I won't
> send the patches with the holes which I knew about.
> 
> Once again, this is just RFC to know your and Masami's opinion. If
> you think this can work, I'll try to resend this series with the
> additional bits to cover instance_delete() too. _Afaics_ this needs
> some temporary uglifications "in between".

I think your proposal goes a good direction, but it also requires
completeness, because, as I pointed, we have to take care of all
operations are correctly checked except for open/close.

So, I agree with Steven, I'd like to see a complete patchset.

Thank you,


-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



  reply	other threads:[~2013-07-18 10:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-16 18:56 [RFC PATCH 0/4] tracing: fix open/delete fixes Oleg Nesterov
2013-07-16 18:57 ` [RFC PATCH 1/4] tracing: Change remove_event_from_tracers() to clear d_subdirs->i_private Oleg Nesterov
2013-07-16 18:57 ` [RFC PATCH 2/4] tracing: Turn "id"->i_private into call->event.type Oleg Nesterov
2013-07-16 19:49   ` Steven Rostedt
2013-07-17 19:39     ` Oleg Nesterov
2013-07-16 18:57 ` [RFC PATCH 3/4] tracing: Kill tracing_open/release_generic_file Oleg Nesterov
2013-07-16 19:51   ` Steven Rostedt
2013-07-17 19:19     ` Oleg Nesterov
2013-07-18 10:56       ` Masami Hiramatsu [this message]
2013-07-18 14:55         ` Oleg Nesterov
2013-07-16 18:57 ` [RFC PATCH 4/4] tracing: Change ftrace_event_filter_fops to rely on event_mutex/i_private Oleg Nesterov
2013-07-17  2:36 ` [RFC PATCH 0/4] tracing: fix open/delete fixes Masami Hiramatsu
2013-07-17 14:43   ` Oleg Nesterov
2013-07-18  8:18     ` Masami Hiramatsu
2013-07-18 15:27       ` Oleg Nesterov
2013-07-17 19:30 ` [RFC PATCH 5/4] tracing: Simplify the ftrace_event_field iteration in f_next/f_show Oleg Nesterov
2013-07-17 19:37   ` Oleg Nesterov
2013-07-17 19:30 ` [RFC PATCH 6/4] tracing: Change f_start() to verify i_private under event_mutex Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E7C9E3.1070506@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=jovi.zhangwei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.