[Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Peter Lieven]

Signed-off-by: Peter Lieven <pl@kamp.de>
---
 block.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index b560241..c7f0197 100644
--- a/block.c
+++ b/block.c
@@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
 
     enabled = bs->io_limits_enabled;
     bs->io_limits_enabled = false;
-    ret = bdrv_read(bs, 0, buf, 1);
+    ret = bdrv_read(bs, sector_num, buf, nb_sectors);
     bs->io_limits_enabled = enabled;
     return ret;
 }
-- 
1.7.9.5

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Paolo Bonzini]

Il 18/07/2013 10:37, Peter Lieven ha scritto:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block.c b/block.c
> index b560241..c7f0197 100644
> --- a/block.c
> +++ b/block.c
> @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
>  
>      enabled = bs->io_limits_enabled;
>      bs->io_limits_enabled = false;
> -    ret = bdrv_read(bs, 0, buf, 1);
> +    ret = bdrv_read(bs, sector_num, buf, nb_sectors);
>      bs->io_limits_enabled = enabled;
>      return ret;
>  }
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Stefan Hajnoczi]

On Thu, Jul 18, 2013 at 10:37:32AM +0200, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Kevin Wolf]

Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  block.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block.c b/block.c
> index b560241..c7f0197 100644
> --- a/block.c
> +++ b/block.c
> @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
>  
>      enabled = bs->io_limits_enabled;
>      bs->io_limits_enabled = false;
> -    ret = bdrv_read(bs, 0, buf, 1);
> +    ret = bdrv_read(bs, sector_num, buf, nb_sectors);
>      bs->io_limits_enabled = enabled;
>      return ret;
>  }

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

The commit message would have deserved a comment about the impact. The
only caller is passing 0 as sector_num and 1 as nb_sectors, so this
doesn't change the behaviour in practice. (Which is the reason why it's
not for qemu-stable.)

Kevin

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

[Peter Lieven]

On 19.07.2013 11:14, Kevin Wolf wrote:
> Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
>> Signed-off-by: Peter Lieven <pl@kamp.de>
>> ---
>>   block.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block.c b/block.c
>> index b560241..c7f0197 100644
>> --- a/block.c
>> +++ b/block.c
>> @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,
>>   
>>       enabled = bs->io_limits_enabled;
>>       bs->io_limits_enabled = false;
>> -    ret = bdrv_read(bs, 0, buf, 1);
>> +    ret = bdrv_read(bs, sector_num, buf, nb_sectors);
>>       bs->io_limits_enabled = enabled;
>>       return ret;
>>   }
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
>
> The commit message would have deserved a comment about the impact. The
> only caller is passing 0 as sector_num and 1 as nb_sectors, so this
> doesn't change the behaviour in practice. (Which is the reason why it's
> not for qemu-stable.)
Yes, I only spotted it while working on 4KN support.

Peter