From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759012Ab3GRNqz (ORCPT ); Thu, 18 Jul 2013 09:46:55 -0400 Received: from smtp.multi.fi ([85.134.37.151]:41243 "EHLO smtp.multi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758247Ab3GRNqy (ORCPT ); Thu, 18 Jul 2013 09:46:54 -0400 Message-ID: <51E7F192.4000004@mageia.org> Date: Thu, 18 Jul 2013 16:45:54 +0300 From: Thomas Backlund User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Neil Horman CC: Kamal Mostafa , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Prarit Bhargava , Don Zickus , Don Dutile , Bjorn Helgaas , Asit Mallick , David Woodhouse , linux-pci@vger.kernel.org, Joerg Roedel , Konrad Rzeszutek Wilk , =?UTF-8?B?QXJrYWRpdXN6IE1pxZtraWV3aWN6?= , Luis Henriques Subject: Re: [PATCH 089/145] iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets References: <1374101277-7915-1-git-send-email-kamal@canonical.com> <1374101277-7915-90-git-send-email-kamal@canonical.com> <51E7A0F8.9000308@mageia.org> <20130718103739.GA3626@hmsreliant.think-freely.org> In-Reply-To: <20130718103739.GA3626@hmsreliant.think-freely.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 18.07.2013 13:37, Neil Horman skrev: > On Thu, Jul 18, 2013 at 11:02:00AM +0300, Thomas Backlund wrote: >> 18.07.2013 01:47, Kamal Mostafa skrev: >>> 3.8.13.5 -stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Neil Horman >>> >>> commit 03bbcb2e7e292838bb0244f5a7816d194c911d62 upstream. >>> >>> A few years back intel published a spec update: >>> http://www.intel.com/content/dam/doc/specification-update/5520-and-5500-chipset-ioh-specification-update.pdf >>> >>> For the 5520 and 5500 chipsets which contained an errata (specificially errata >>> 53), which noted that these chipsets can't properly do interrupt remapping, and >>> as a result the recommend that interrupt remapping be disabled in bios. While >>> many vendors have a bios update to do exactly that, not all do, and of course >>> not all users update their bios to a level that corrects the problem. As a >>> result, occasionally interrupts can arrive at a cpu even after affinity for that >>> interrupt has be moved, leading to lost or spurrious interrupts (usually >>> characterized by the message: >>> kernel: do_IRQ: 7.71 No irq handler for vector (irq -1) >>> >>> There have been several incidents recently of people seeing this error, and >>> investigation has shown that they have system for which their BIOS level is such >>> that this feature was not properly turned off. As such, it would be good to >>> give them a reminder that their systems are vulnurable to this problem. For >>> details of those that reported the problem, please see: >>> https://bugzilla.redhat.com/show_bug.cgi?id=887006 >>> >>> [ Joerg: Removed CONFIG_IRQ_REMAP ifdef from early-quirks.c ] >>> >>> Signed-off-by: Neil Horman >>> CC: Prarit Bhargava >>> CC: Don Zickus >>> CC: Don Dutile >>> CC: Bjorn Helgaas >>> CC: Asit Mallick >>> CC: David Woodhouse >>> CC: linux-pci@vger.kernel.org >>> CC: Joerg Roedel >>> CC: Konrad Rzeszutek Wilk >>> CC: Arkadiusz Miśkiewicz >>> Signed-off-by: Joerg Roedel >>> Signed-off-by: Luis Henriques >>> --- >>> arch/x86/include/asm/irq_remapping.h | 2 ++ >>> arch/x86/kernel/early-quirks.c | 20 ++++++++++++++++++++ >>> drivers/iommu/intel_irq_remapping.c | 10 ++++++++++ >>> drivers/iommu/irq_remapping.c | 6 ++++++ >>> drivers/iommu/irq_remapping.h | 2 ++ >>> 5 files changed, 40 insertions(+) >>> >> >> This patch introduces this warning on 3.8 series kernels: >> >> In file included from arch/x86/kernel/early-quirks.c:21:0: >> /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:46:10: >> varning: ”struct irq_data” deklarerad inuti parameterlista >> [aktiverat som standard] >> /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:46:10: >> varning: dess scope-område är endast denna definition eller >> deklaration, vilket troligen inte är vad du vill. [aktiverat som >> standard] >> /kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:50:17: >> varning: ”struct msi_msg” deklarerad inuti parameterlista [aktiverat >> som standard] >> >> >> You need to add this upstream fix too: >> >> commit 35d3d814cbd46a85bed97cd74ba97fbbb51e0ccd >> Author: Joerg Roedel >> Date: Fri Apr 19 20:34:55 2013 +0200 >> >> iommu: Fix compile warnings with forward declarations >> > I submited a 3.9 backport that included that fix to -stable over a week ago, you > should just be able to use that if you want. > Neil Almost, but not enough... The patch you refer to was: [3.9 stable PATCH] iommu/vt-d: add quirk for broken interrupt remapping on 55XX chipsets and got merged in 3.9.9. And that added a missing: "#include " in arch/x86/include/asm/irq_remapping.h But using that patch it still spits out: kernel/linux-3.8.13.5/arch/x86/include/asm/irq_remapping.h:50:17: >> varning: ”struct msi_msg” deklarerad inuti parameterlista [aktiverat >> som standard] which is why the additional patch is still needed... -- Thomas