From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztFl-0006TN-8r for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UztFk-00025O-0l for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:48:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UztFj-00025J-O6 for qemu-devel@nongnu.org; Thu, 18 Jul 2013 14:48:35 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6IImZ0V026700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jul 2013 14:48:35 -0400 Message-ID: <51E83882.5010400@redhat.com> Date: Thu, 18 Jul 2013 12:48:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1374091462-18391-1-git-send-email-imain@redhat.com> <1374091462-18391-5-git-send-email-imain@redhat.com> <51E82579.20201@redhat.com> <51E826C4.6090300@redhat.com> <20130718180339.GA13675@gate.mains.priv> In-Reply-To: <20130718180339.GA13675@gate.mains.priv> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uscpsgXU20Nn7nbGv5mKKllIfpn8wlokw" Subject: Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Main Cc: "kwolf@redhat.com" , Fam Zheng , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uscpsgXU20Nn7nbGv5mKKllIfpn8wlokw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/18/2013 12:03 PM, Ian Main wrote: >> >> Or we could simplify life by making 'format' mandatory for drive-backu= p; >> it was optional for 'drive-mirror' due to incremental implementation, >> but for 'drive-backup', we still have the opportunity to do things rig= ht >> from the first release. >=20 > Ah, I did make a doc change, I must have forgotten to add it. >=20 > I'm all for making format mandatory if that is ok with everyone. Maybe= > that is the best solution. We can always change our mind in 1.7 to make it optional if we change our minds, but I'd definitely like to see patches that make 'format' mandatory for DriveBackup for 1.6 - simpler all around. Converting mandatory to optional is discoverable via introspection; while converting optional to mandatory is an API break. And since we can argue that optional formats is relatively risky, it's better to have our initial release be conservative by requiring the field until (and unless) someone comes up with a use case why leaving it unspecified makes a difference. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uscpsgXU20Nn7nbGv5mKKllIfpn8wlokw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJR6DiCAAoJEKeha0olJ0NqEU0IAKubq6P6+ZtgSRuTaRkRxnSl GA9AYm00encTQXaNTB5H6Fwz9L/odL0AQYrf69OrMB9+e3MO3kcqkiqEfLxvbuxc 366FJda59Z4iAuTH0MR8sSty3pd8AyVffWKXNrLHlV84oeVr0HxeaW8FF3LdHvmB AcemwIngEtN5eRJg+15KeaVos4t0Is5whdLSSZFx/BixA6NkCTTi0YZxzZoGFT45 fzGPnmJCNZBDIrbHlZhiod5+FFPXo2PLLe8HiQ+lbJnzBciD4teKlhmNJVWV0T9N 1i6ZthOapHO5CuNgqZoHeuC2RgTIK5dwn133E+dwCLGna9otzNr8jdw3eefndUk= =zgQa -----END PGP SIGNATURE----- --uscpsgXU20Nn7nbGv5mKKllIfpn8wlokw--