From: Eric Blake <eblake@redhat.com>
To: Ian Main <imain@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none.
Date: Thu, 18 Jul 2013 12:56:51 -0600 [thread overview]
Message-ID: <51E83A73.9070501@redhat.com> (raw)
In-Reply-To: <1374173251-19449-1-git-send-email-imain@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On 07/18/2013 12:47 PM, Ian Main wrote:
> qcow2 supports backing files so it makes sense to default to qcow2
> for MIRROR_SYNC_MODE_NONE so that we can use the source as a backing
> drive and export it via nbd. Defaulting FULL and TOP to SYNC_MODE_NONE
> breaks tests but that could be fixed if we wanted it.
>
> Signed-off-by: Ian Main <imain@redhat.com>
> ---
> blockdev.c | 5 ++++-
> qapi-schema.json | 1 +
> 2 files changed, 5 insertions(+), 1 deletion(-)
Looks okay, but let's answer the meta-question first of whether we
should just make 'format' mandatory and be done with it.
Also, I've noticed you aren't cc'ing many people; that can slow down
reviews. http://wiki.qemu.org/Contribute/SubmitAPatch gives hints on
how to determine the right people to send your patches to, by
deciphering MAINTAINERS and running ./scripts/getmaintainer.pl.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-07-18 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 18:47 [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none Ian Main
2013-07-18 18:56 ` Eric Blake [this message]
2013-07-18 19:13 ` Ian Main
2013-07-18 19:55 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2013-07-17 20:04 [Qemu-devel] [PATCH V4 0/4] Implement sync modes for drive-backup Ian Main
2013-07-17 20:04 ` [Qemu-devel] [PATCH V4 4/4] Change default to qcow2 for sync mode none Ian Main
2013-07-18 17:27 ` Eric Blake
2013-07-18 17:32 ` Eric Blake
2013-07-18 18:03 ` Ian Main
2013-07-18 18:48 ` Eric Blake
2013-07-18 18:06 ` Ian Main
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E83A73.9070501@redhat.com \
--to=eblake@redhat.com \
--cc=imain@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.