From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0U9M-0001rJ-JE for qemu-devel@nongnu.org; Sat, 20 Jul 2013 06:12:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0U9L-0005Q9-Md for qemu-devel@nongnu.org; Sat, 20 Jul 2013 06:12:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0U9L-0005Q5-EY for qemu-devel@nongnu.org; Sat, 20 Jul 2013 06:12:27 -0400 Message-ID: <51EA6256.8090501@redhat.com> Date: Sat, 20 Jul 2013 12:11:34 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <51C75FA6.6080903@reactos.org> <51C7E21A.9090005@web.de> <8A36D64D-0625-49E1-9E59-391DAEEBD1FC@suse.de> <51E91E7D.1000302@ozlabs.ru> <51E935C0.3020703@redhat.com> <51E95FDD.6080306@ozlabs.ru> <51E9E00F.6050807@ozlabs.ru> <51E9E3C4.2040002@ozlabs.ru> In-Reply-To: <51E9E3C4.2040002@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] BUG: Re: [PATCH v3 11/14] ioport: Switch dispatching to memory core layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Liu Ping Fan , Alexander Graf , qemu-devel , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , "Aneesh Kumar K.V" , "anthony@codemonkey.ws" , "Edgar E. Iglesias" , Jan Kiszka , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Aurelien Jarno Il 20/07/2013 03:11, Alexey Kardashevskiy ha scritto: > On 07/20/2013 10:55 AM, Alexey Kardashevskiy wrote: >> On 07/20/2013 01:48 AM, Alexey Kardashevskiy wrote: >>> Ok. So. >>> >>> What broke is... >>> I could try explaining but backtraces are lot better :) >>> >>> Shortly - virtio_pci_config_ops.endianness was ignored before (was bad but >>> we had a workaround in spapr_io_ops), now it works so double swap happens >>> and everything gets broken. >>> >>> If we talk about VGA (in powerpc, it is all about powerpc), I guess >>> memory_region_iorange_write() will go through mr->ops->old_portio branch >>> and won't do any byte swapping (so spapr_io_ops will do the job), so we are >>> fine here. I do not understand yet why it works on mac99 though, too late >>> here :) >> >> I understood. VGA does not work for mac99 either with this command line: >> ./qemu-system-ppc64 -m "1024" -M "mac99" -vga "std" >> So it works for pseries only because of parity bug in spapr_io_ops. Yes, this is what Herve was fixing for PREP too. > oops. I am wrong and VGA works on mac99 in upstream because isa_mmio_ops > does the swapping in this case and portio_ops does not swap (in upstream). Uff... I guess we have to look at all cases for big-endian machines, and make sure there is an odd number of exchanges. Aurelien/Alex/Herve, where can I find images for mips malta, mips jazz, ppc4xx and prep? Edgar, what about sh4eb (IIRC one of the two machine types supported PCI)? Also, is all the firmware included in pc-bios/? For g3beige and mac99 I can use mintppc, I think, that's what I installed on my old G4 PowerBook. Paolo