From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V19qv-0003it-Cx for qemu-devel@nongnu.org; Mon, 22 Jul 2013 02:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V19qu-0007Hq-Gu for qemu-devel@nongnu.org; Mon, 22 Jul 2013 02:44:13 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:51585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V19qt-0007Gj-T4 for qemu-devel@nongnu.org; Mon, 22 Jul 2013 02:44:12 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 22 Jul 2013 16:34:31 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 4F0792CE804C for ; Mon, 22 Jul 2013 16:44:04 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6M6SXTt59113514 for ; Mon, 22 Jul 2013 16:28:33 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6M6i2lI006492 for ; Mon, 22 Jul 2013 16:44:02 +1000 Message-ID: <51ECD49A.5050104@linux.vnet.ibm.com> Date: Mon, 22 Jul 2013 14:43:38 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374464794-13057-1-git-send-email-famz@redhat.com> In-Reply-To: <1374464794-13057-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/2] block: allow commit active as top List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, jcody@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com ÓÚ 2013-7-22 11:46, Fam Zheng дµÀ: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > Please see commit messages for implementation details. > > Fam Zheng (2): > block: allow live commit of active image > qemu-iotests: update test cases for commit active > > block.c | 102 ++++++++++--------------------- > block/commit.c | 160 +++++++++++++++++++++++++------------------------ > include/block/block.h | 5 +- > tests/qemu-iotests/040 | 68 ++++++++------------- > 4 files changed, 141 insertions(+), 194 deletions(-) > I have thought the commit with top issue before, a question comes to me: what is the relationship with block-stream? for example: base->mid->top you can block-stream mid to top(if I remember correctly), result is: base->(mid+top) with this patch, you can block-commit top to mid, result is: base->(mod+top) it seems the function is duplicated. Maybe you can raise another good user case. I must say it may help user to do every thing with block-commit, but if you find it is too much to make it work, maybe you can postpond it, since block-stream is available. -- Best Regards Wenchao Xia