From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Shijie Subject: Re: support DUAL and QUAD[patch v1] Date: Mon, 22 Jul 2013 18:32:55 +0800 Message-ID: <51ED0A57.4060105@freescale.com> References: <20980858CB6D3A4BAE95CA194937D5E73E9E84D2@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73E9E851E@DBDE04.ent.ti.com> <593AEF6C47F46446852B067021A273D6D93B49E1@MUCSE039.lantiq.com> <20980858CB6D3A4BAE95CA194937D5E73E9E85D0@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73E9E967D@DBDE04.ent.ti.com> <20130722093342.GJ9858@sirena.org.uk> <20980858CB6D3A4BAE95CA194937D5E73E9EC9B1@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: "thomas.langer@lantiq.com" , Mark Brown , "linux-mtd@lists.infradead.org" , "spi-devel-general@lists.sourceforge.net" , "Poddar, Sourav" , Trent Piepho , yuhang wang To: "Gupta, Pekon" Return-path: In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9EC9B1@DBDE04.ent.ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org List-Id: linux-spi.vger.kernel.org 5LqOIDIwMTPlubQwN+aciDIy5pelIDE3OjU2LCBHdXB0YSwgUGVrb24g5YaZ6YGTOgo+IChiKSBz dHJ1Y3Qgc3BpX3RyYW5zZmVyOiBpZiBlYWNoIHRyYW5zZmVyIG9mIHNhbWUgbWVzc2FnZSBuZWVk IHRvIGJlCj4gdHJhbnNmZXJyZWQgYXQgZGlmZmVyZW50IHdpZHRoLiAJRXhhbXBsZTogQ29tbWFu ZCBAIFNpbmdsZS1TUEkKPiAgIGZvbGxvd2VkIGJ5IERhdGEgQCBRdWFkLVNQSQo+CkkgYW0gY29k aW5nIHRoZSBRdWFkU3BpIGRyaXZlciBmb3IgRnJlZXNjYWxlJ3MgVnlicmlkIG5vdy4KCkkgdGhp bmsgd2UgZG90IG5lZWQgdG8gY2hhbmdlIHRoZSBzcGkgY29kZS4KdGhlIHNwaSBsYXllciBzaG91 bGQgbm90IGtub3cgdGhlIGRpZmZlcmVudCB3aWR0aCBvZiB0aGUgY29tbWFuZCBhbmQgdGhlIApk YXRhLApsZXQgdGhlIHFzcGkgZHJpdmVyIGRvZXMgaXQuCgpJbiB0aGUgbTI1cF9wcm9iZSgpLCBh ZnRlciB3ZSBrbm93cyB0aGF0IHRoZSBxc3BpIGRyaXZlciBhbmQgZmxhc2ggCnN1cHBvcnQgdGhl IFF1YWQgcmVhZCwgc28gd2UgY2FuIHNldCB0aGUKbTI1cC0+cmVhZF9vcGNvZGUgdG8gMHhlYiBv ciAweGVjLiBJbiB0aGUgcXNwaSBkcml2ZXIsIGl0IGNhbiBkbyB0aGUgCnJlYWwgam9iLgoKCnRo YW5rcwpIdWFuZyBTaGlqaWUKCgoKCgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlz dApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tx2ehsobe004.messaging.microsoft.com ([65.55.88.14] helo=tx2outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V1DMY-0004Sd-8o for linux-mtd@lists.infradead.org; Mon, 22 Jul 2013 10:29:06 +0000 Message-ID: <51ED0A57.4060105@freescale.com> Date: Mon, 22 Jul 2013 18:32:55 +0800 From: Huang Shijie MIME-Version: 1.0 To: "Gupta, Pekon" Subject: Re: support DUAL and QUAD[patch v1] References: <20980858CB6D3A4BAE95CA194937D5E73E9E84D2@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73E9E851E@DBDE04.ent.ti.com> <593AEF6C47F46446852B067021A273D6D93B49E1@MUCSE039.lantiq.com> <20980858CB6D3A4BAE95CA194937D5E73E9E85D0@DBDE04.ent.ti.com> <20980858CB6D3A4BAE95CA194937D5E73E9E967D@DBDE04.ent.ti.com> <20130722093342.GJ9858@sirena.org.uk> <20980858CB6D3A4BAE95CA194937D5E73E9EC9B1@DBDE04.ent.ti.com> In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73E9EC9B1@DBDE04.ent.ti.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: "thomas.langer@lantiq.com" , Mark Brown , "linux-mtd@lists.infradead.org" , "spi-devel-general@lists.sourceforge.net" , "Poddar, Sourav" , Trent Piepho , yuhang wang List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , =E4=BA=8E 2013=E5=B9=B407=E6=9C=8822=E6=97=A5 17:56, Gupta, Pekon =E5=86=99= =E9=81=93: > (b) struct spi_transfer: if each transfer of same message need to be > transferred at different width. Example: Command @ Single-SPI > followed by Data @ Quad-SPI > I am coding the QuadSpi driver for Freescale's Vybrid now. I think we dot need to change the spi code. the spi layer should not know the different width of the command and the=20 data, let the qspi driver does it. In the m25p_probe(), after we knows that the qspi driver and flash=20 support the Quad read, so we can set the m25p->read_opcode to 0xeb or 0xec. In the qspi driver, it can do the=20 real job. thanks Huang Shijie