On 07/22/2013 02:14 PM, Gerhard Sittig wrote: > make the Freescale ethernet driver get, prepare and enable the FEC clock > during probe(); disable, unprepare and put the clock upon remove(); hold > a reference to the clock over the period of use; use devm_{get,put}_clk() There's no need for devm_clk_put(), devm will take care of this. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |