From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1K3E-0001Q5-8G for qemu-devel@nongnu.org; Mon, 22 Jul 2013 13:37:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1K39-00056i-Ur for qemu-devel@nongnu.org; Mon, 22 Jul 2013 13:37:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35493 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1JoK-0007cV-6h for qemu-devel@nongnu.org; Mon, 22 Jul 2013 13:22:12 -0400 Message-ID: <51ED6A41.6000108@suse.de> Date: Mon, 22 Jul 2013 19:22:09 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1374415744-6675-1-git-send-email-afaerber@suse.de> <20130721202644.GB15187@redhat.com> In-Reply-To: <20130721202644.GB15187@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-next 0/4] QOM'ification of pci-bridge types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Paolo Bonzini , Peter Crosthwaite , qemu-devel@nongnu.org, Anthony Liguori , Hu Tao Am 21.07.2013 22:26, schrieb Michael S. Tsirkin: > On Sun, Jul 21, 2013 at 04:09:00PM +0200, Andreas F=E4rber wrote: >> Hello Michael et al., >> >> This series turns PCIBridge, PCIEPort and PCIESlot into abstract QOM t= ypes, >> so that we can use QOM casts to obtain a pointer. >> >> Possibly this was prompted by q35's PCIe? >=20 > What was prompted? This refactoring series. > What's the question exactly? Why I prepared this series on an offline train ride on Wednesday. ;) Not for you to answer - something PCIe must've gotten in the way of some QOM realize conversion but the branch is missing the final patch showing what these types and casts are good for. Since we're in Soft Freeze I rather wanted to flush my queues for review though rather than spend more time puzzling why I did this. :) Andreas >=20 >> Don't remember ATM... >> >> Regards, >> Andreas >> >> Cc: Anthony Liguori >> Cc: Paolo Bonzini >> Cc: Michael S. Tsirkin >> Cc: Peter Crosthwaite >> Cc: Hu Tao >> >> Andreas F=E4rber (4): >> pci-bridge: Turn into abstract QOM type >> pci-bridge-dev: QOM parent field cleanup >> pci-bridge/i82801b11: Rename parent field >> pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types >> >> hw/pci-bridge/dec.c | 4 ++-- >> hw/pci-bridge/i82801b11.c | 10 ++++++---- >> hw/pci-bridge/ioh3420.c | 29 +++++++++++++-------------- >> hw/pci-bridge/pci_bridge_dev.c | 26 +++++++++++++++---------- >> hw/pci-bridge/xio3130_downstream.c | 29 +++++++++++++-------------- >> hw/pci-bridge/xio3130_upstream.c | 20 +++++++++---------- >> hw/pci-host/apb.c | 4 ++-- >> hw/pci/pci_bridge.c | 40 +++++++++++++++++++++++++++--= --------- >> hw/pci/pcie.c | 2 +- >> hw/pci/pcie_port.c | 22 +++++++++++++++++++++ >> include/hw/pci/pci_bus.h | 7 ++++++- >> include/hw/pci/pcie_port.h | 14 +++++++++++-- >> 12 files changed, 132 insertions(+), 75 deletions(-) >> >> --=20 >> 1.8.1.4 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg