From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 56C3A29E11 for ; Fri, 26 Jul 2013 10:07:15 -0500 (CDT) Message-ID: <51F2909F.6040107@sgi.com> Date: Fri, 26 Jul 2013 10:07:11 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 29/49] xfs: kill __KERNEL__ check for debug code in allocation code References: <1374215120-7271-1-git-send-email-david@fromorbit.com> <1374215120-7271-30-git-send-email-david@fromorbit.com> In-Reply-To: <1374215120-7271-30-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 07/19/13 01:25, Dave Chinner wrote: > From: Dave Chinner > > Userspace running debug builds is relatively rare, so there's need > to special case the allocation algorithm code coverage debug switch. > As it is, userspace defines random numbers to 0, so invert the > logic of the switch so it is effectively a no-op in userspace. > This kills another couple of __KERNEL__ users. > > Signed-off-by: Dave Chinner > --- No functional change for the kernel. skipping the first allocation algorithm is still 50% for debug kernels. Change is for user space. Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs