From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3QLw-000771-Gb for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:45:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3QLq-00024k-5R for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:45:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60097 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3QLp-00024f-TC for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:45:30 -0400 Message-ID: <51F51262.1090808@suse.de> Date: Sun, 28 Jul 2013 14:45:22 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1375014954-31916-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1375014954-31916-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 28.07.2013 14:35, schrieb Paolo Bonzini: > This is quite handy to debug softmmu targets. >=20 > Signed-off-by: Paolo Bonzini > --- > memory.c | 5 +++++ > trace-events | 4 ++++ > 2 files changed, 9 insertions(+) >=20 > diff --git a/memory.c b/memory.c > index 1494e95..ac6f3c6 100644 > --- a/memory.c > +++ b/memory.c > @@ -19,6 +19,7 @@ > #include "qemu/bitops.h" > #include "qom/object.h" > #include "sysemu/kvm.h" > +#include "trace.h" > #include > =20 > #include "exec/memory-internal.h" > @@ -388,6 +389,7 @@ static void memory_region_oldmmio_read_accessor(Mem= oryRegion *mr, > uint64_t tmp; > =20 > tmp =3D mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); > + trace_memory_region_ops_read(mr, addr, tmp, size); > *value |=3D (tmp & mask) << shift; > } > =20 > @@ -404,6 +406,7 @@ static void memory_region_read_accessor(MemoryRegio= n *mr, > qemu_flush_coalesced_mmio_buffer(); > } > tmp =3D mr->ops->read(mr->opaque, addr, size); > + trace_memory_region_ops_read(mr, addr, tmp, size); > *value |=3D (tmp & mask) << shift; > } > =20 > @@ -417,6 +420,7 @@ static void memory_region_oldmmio_write_accessor(Me= moryRegion *mr, > uint64_t tmp; > =20 > tmp =3D (*value >> shift) & mask; > + trace_memory_region_ops_write(mr, addr, tmp, size); > mr->ops->old_mmio.write[ctz32(size)](mr->opaque, addr, tmp); > } > =20 > @@ -433,6 +437,7 @@ static void memory_region_write_accessor(MemoryRegi= on *mr, > qemu_flush_coalesced_mmio_buffer(); > } > tmp =3D (*value >> shift) & mask; > + trace_memory_region_ops_write(mr, addr, tmp, size); > mr->ops->write(mr->opaque, addr, tmp, size); > } > =20 > diff --git a/trace-events b/trace-events > index 002df83..3e0dd74 100644 > --- a/trace-events > +++ b/trace-events > @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, arg = %p" > kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type= %d, arg %p" > kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d" > =20 > +# memory.c > +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsign= ed size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" > +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsig= ned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" %u would seem more correct for unsigned - if you fix that, Reviewed-by: Andreas F=E4rber and ACK that's it's good for 1.6. Andreas > + > # qom/object.c > object_dynamic_cast_assert(const char *type, const char *target, const= char *file, int line, const char *func) "%s->%s (%s:%d:%s)" > object_class_dynamic_cast_assert(const char *type, const char *target,= const char *file, int line, const char *func) "%s->%s (%s:%d:%s)" >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg