From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3QVv-0003JK-A7 for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:56:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3QVo-0005Rx-Nf for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:55:55 -0400 Received: from mail-we0-x22b.google.com ([2a00:1450:400c:c03::22b]:61678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3QVo-0005Ri-GY for qemu-devel@nongnu.org; Sun, 28 Jul 2013 08:55:48 -0400 Received: by mail-we0-f171.google.com with SMTP id q55so3208073wes.30 for ; Sun, 28 Jul 2013 05:55:47 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51F514C1.3030003@redhat.com> Date: Sun, 28 Jul 2013 14:55:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1375014954-31916-1-git-send-email-pbonzini@redhat.com> <51F51262.1090808@suse.de> In-Reply-To: <51F51262.1090808@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO reads/writes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org Il 28/07/2013 14:45, Andreas Färber ha scritto: > Am 28.07.2013 14:35, schrieb Paolo Bonzini: >> This is quite handy to debug softmmu targets. >> >> Signed-off-by: Paolo Bonzini >> --- >> memory.c | 5 +++++ >> trace-events | 4 ++++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/memory.c b/memory.c >> index 1494e95..ac6f3c6 100644 >> --- a/memory.c >> +++ b/memory.c >> @@ -19,6 +19,7 @@ >> #include "qemu/bitops.h" >> #include "qom/object.h" >> #include "sysemu/kvm.h" >> +#include "trace.h" >> #include >> >> #include "exec/memory-internal.h" >> @@ -388,6 +389,7 @@ static void memory_region_oldmmio_read_accessor(MemoryRegion *mr, >> uint64_t tmp; >> >> tmp = mr->ops->old_mmio.read[ctz32(size)](mr->opaque, addr); >> + trace_memory_region_ops_read(mr, addr, tmp, size); >> *value |= (tmp & mask) << shift; >> } >> >> @@ -404,6 +406,7 @@ static void memory_region_read_accessor(MemoryRegion *mr, >> qemu_flush_coalesced_mmio_buffer(); >> } >> tmp = mr->ops->read(mr->opaque, addr, size); >> + trace_memory_region_ops_read(mr, addr, tmp, size); >> *value |= (tmp & mask) << shift; >> } >> >> @@ -417,6 +420,7 @@ static void memory_region_oldmmio_write_accessor(MemoryRegion *mr, >> uint64_t tmp; >> >> tmp = (*value >> shift) & mask; >> + trace_memory_region_ops_write(mr, addr, tmp, size); >> mr->ops->old_mmio.write[ctz32(size)](mr->opaque, addr, tmp); >> } >> >> @@ -433,6 +437,7 @@ static void memory_region_write_accessor(MemoryRegion *mr, >> qemu_flush_coalesced_mmio_buffer(); >> } >> tmp = (*value >> shift) & mask; >> + trace_memory_region_ops_write(mr, addr, tmp, size); >> mr->ops->write(mr->opaque, addr, tmp, size); >> } >> >> diff --git a/trace-events b/trace-events >> index 002df83..3e0dd74 100644 >> --- a/trace-events >> +++ b/trace-events >> @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, arg %p" >> kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p" >> kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d" >> >> +# memory.c >> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" >> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value, unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d" > > %u would seem more correct for unsigned - if you fix that, Reviewed-by: > Andreas Färber and ACK that's it's good for 1.6. Ok, though it can only be 1/2/4/8. Paolo