From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3SUA-0006TF-8N
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:02:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3SU2-0002ok-VR
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:02:14 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34215 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1V3SU2-0002oa-PC
	for qemu-devel@nongnu.org; Sun, 28 Jul 2013 11:02:06 -0400
Message-ID: <51F53269.5000503@suse.de>
Date: Sun, 28 Jul 2013 17:02:01 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1375014954-31916-1-git-send-email-pbonzini@redhat.com>
	<CAFEAcA82A1k+x3cL_Wanhen-A+Hd_DXQtybZ0gZCOGphg0Z7Qw@mail.gmail.com>
In-Reply-To: <CAFEAcA82A1k+x3cL_Wanhen-A+Hd_DXQtybZ0gZCOGphg0Z7Qw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO
 reads/writes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 28.07.2013 16:34, schrieb Peter Maydell:
> On 28 July 2013 13:35, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> This is quite handy to debug softmmu targets.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>=20
> (not a nak, just a tangential thought)
> It would be cute if you could just insert a "trace this access
> and pass it through" container MemoryRegion at an arbitrary
> point in the memory region hierarchy. That would let us do
> "trace accesses to device X" without device X having to
> have boilerplate tracing code in its read/write functions.

The SystemTap backend for instance allows you to filter what you print
based on arguments, i.e. address and size.

Are you suggesting to make the trace points in this patch conditional on
some new mr->tracing_enabled flag in the MemoryRegion?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg