From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for internal snapshot export
Date: Mon, 29 Jul 2013 09:57:32 +0800 [thread overview]
Message-ID: <51F5CC0C.3070305@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130726081134.GA31438@stefanha-thinkpad.redhat.com>
于 2013-7-26 16:11, Stefan Hajnoczi 写道:
> On Wed, Jul 17, 2013 at 10:03:54PM +0800, Wenchao Xia wrote:
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>> qemu-nbd.c | 2 ++
>> qemu-nbd.texi | 3 +++
>> 2 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-nbd.c b/qemu-nbd.c
>> index 46be2b2..8eeee33 100644
>> --- a/qemu-nbd.c
>> +++ b/qemu-nbd.c
>> @@ -80,6 +80,8 @@ static void usage(const char *name)
>> "Block device options:\n"
>> " -r, --read-only export read-only\n"
>> " -s, --snapshot use snapshot file\n"
>> +" -l, --snapshot-load temporarily load an internal snapshot and export it as\n"
>> +" an read-only device, format is 'id=[ID],name=[NAME]'\n"
>
> Does it really export it read-only? I think you'll get an error unless
> you pass qemu-nbd --read-only.
>
I think so. In patch 2:
+ case 'l':
+ sn_param = parse_option_parameters(optarg,
+ snapshot_options, sn_param);
+ if (!sn_param) {
+ errx(EXIT_FAILURE,
+ "Invalid snapshot-load options '%s'", optarg);
+ }
case 'r':
nbdflags |= NBD_FLAG_READ_ONLY;
flags &= ~BDRV_O_RDWR;
when "l" is set, readonly will also be set.
--
Best Regards
Wenchao Xia
next prev parent reply other threads:[~2013-07-29 1:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 14:03 [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 1/4] snapshot: distinguish id and name in load_tmp Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 2/4] qemu-nbd: support internal snapshot export Wenchao Xia
2013-07-17 14:03 ` [Qemu-devel] [PATCH 3/4] qemu-nbd: add doc for " Wenchao Xia
2013-07-26 8:11 ` Stefan Hajnoczi
2013-07-29 1:57 ` Wenchao Xia [this message]
2013-07-29 7:39 ` Stefan Hajnoczi
2013-07-17 14:03 ` [Qemu-devel] [PATCH 4/4] qemu-iotests: add 057 internal snapshot export with qemu-nbd case Wenchao Xia
2013-07-17 14:23 ` [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd Eric Blake
2013-07-17 15:21 ` Kevin Wolf
2013-07-18 2:28 ` Wenchao Xia
2013-07-18 7:15 ` Fam Zheng
2013-07-19 6:29 ` Wenchao Xia
2013-07-19 8:20 ` Kevin Wolf
2013-07-22 5:20 ` Wenchao Xia
2013-07-18 5:43 ` Stefan Hajnoczi
2013-07-19 9:03 ` Wenchao Xia
2013-07-19 9:19 ` Kevin Wolf
2013-07-19 10:02 ` Wenchao Xia
2013-07-22 2:10 ` Fam Zheng
2013-07-22 3:26 ` Wenchao Xia
2013-07-25 2:30 ` Wenchao Xia
2013-07-25 8:06 ` Stefan Hajnoczi
2013-07-26 2:23 ` Wenchao Xia
2013-07-26 8:20 ` Stefan Hajnoczi
2013-07-29 2:05 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F5CC0C.3070305@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.