From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3cqd-0005Fm-7z for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3cqU-0006Zi-Bh for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:06:07 -0400 Received: from e28smtp09.in.ibm.com ([122.248.162.9]:59606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3cqT-0006Zc-PE for qemu-devel@nongnu.org; Sun, 28 Jul 2013 22:05:58 -0400 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 29 Jul 2013 07:30:31 +0530 Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id E40F8E004F for ; Mon, 29 Jul 2013 07:35:56 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r6T25mBQ47513738 for ; Mon, 29 Jul 2013 07:35:48 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r6T25oDd003406 for ; Mon, 29 Jul 2013 12:05:51 +1000 Message-ID: <51F5CDFA.6030400@linux.vnet.ibm.com> Date: Mon, 29 Jul 2013 10:05:46 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1374069835-14287-1-git-send-email-xiawenc@linux.vnet.ibm.com> <51F08DD9.8010301@linux.vnet.ibm.com> <20130725080630.GD19151@stefanha-thinkpad.redhat.com> <51F1DD9C.9090405@linux.vnet.ibm.com> <20130726082057.GB31438@stefanha-thinkpad.redhat.com> In-Reply-To: <20130726082057.GB31438@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, dietmar@proxmox.com ÓÚ 2013-7-26 16:20, Stefan Hajnoczi дµÀ: > On Fri, Jul 26, 2013 at 10:23:24AM +0800, Wenchao Xia wrote: >> ÓÚ 2013-7-25 16:06, Stefan Hajnoczi дµÀ: >>> On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote: >>>> Besides the argument, I think it helps to probe snapshot without >>>> qemu-img convert, hope to get comments for the code. >>> >>> Hi Wenchao, >>> Which patch are you referring to? >>> >>> Stefan >>> >> This series, which enable qemu-nbd load a snapshot. It is quite >> simple, look forward to your opinion, especially the parameter of >> qemu-nbd part in patch 2. > > I understand now. Adding bdrv_snapshot_load_tmp() support to qemu-nbd > is useful, it's a shame that the --snapshot/-s option is already taken > and likely to cause confusion. The documentation needs to be very clear > that --snapshot and --snapshot-load refer to different snapshot > concepts. > I'll add that section about the difference. > Stefan > -- Best Regards Wenchao Xia