Re: [PATCH 0 of 4 RFC] xl - Remus network buffering support

["Roger Pau Monné" <roger.pau@citrix.com>]

On 25/07/13 09:09, Shriram Rajagopalan wrote:
> This patch series adds support for network buffering in the Remus
> codebase in xl/libxl. In previous emails, I had proposed for a script
> invocation to setup network buffering. After digging through libnl API,
> I managed to find most of what I needed (except for one command, which
> right now is executed through system() call).
> 
> The patch series in its current state would allow xl to dynamically setup
> and teardown buffering devices, qdiscs, etc associated with the guest,
> instead of resorting to clunky one time configurations.
> 
> The series is organized as follows:
>  1/4 - Network buffering setup functions - abstractions built on top of libnl3 API
>        to implement functionality such as add/delete qdisc, interface up/down,
>        search for free ifb devices, etc.           
> 
>  2/4 - xl cmdline utility uses these abstractions to setup network buffers and
>        provides libxl with a list of ifb devices where packets would be buffered
> 
>  3/4 - Libxl interaction with network buffer module in the kernel via libnl3.
> 
>  4/4 - adds libnl3 (>= v3.2.17) dependency to autoconf scripts and linker flags
>        in tools/libxl/Makefile. 
> 
> Functionality tested on debian squeeze (kernel 3.4) + openvswitch + 64-bit PV domU (kernel 3.4).

I've just skimmed quickly through the patches, but it seems like they
add a bunch of Linux specific code to general parts of libxl, which
would prevent building or using libxl in any OS different than Linux. If
you have to add Linux specific code there's libxl_linux.c, but please
remember to also add the necessary stubs to libxl_netbsd.c in order to
not break libxl for OSes different than Linux.