All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings
Date: Wed, 31 Jul 2013 08:16:59 +0000	[thread overview]
Message-ID: <51F8C7FB.6070601@bfs.de> (raw)
In-Reply-To: <1375205737-3468-1-git-send-email-emilgoode@gmail.com>



Am 30.07.2013 19:35, schrieb Emil Goode:
> This patch fixes the following sparse warnings.
> dma_addr_t can be either u32 or u64 so we should cast to the
> largest type and use the format specifier %llx.
> 
> drivers/spi/spi-atmel.c: In function ‘atmel_spi_next_xfer_dma_submit’:
> drivers/spi/spi-atmel.c:631:2: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 7 has type ‘dma_addr_t’ [-Wformat]

maybe a %p is better here?

re,
 wh

> drivers/spi/spi-atmel.c:631:2: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 9 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c: In function ‘atmel_spi_pdc_next_xfer’:
> drivers/spi/spi-atmel.c:734:3: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 7 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:734:3: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 9 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:773:3: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 7 has type ‘dma_addr_t’ [-Wformat]
> drivers/spi/spi-atmel.c:773:3: warning:
> 	format ‘%x’ expects argument of type ‘unsigned int’,
> 	but argument 9 has type ‘dma_addr_t’ [-Wformat]
> 
> Signed-off-by: Emil Goode <emilgoode@gmail.com>
> ---
>  drivers/spi/spi-atmel.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
> index 4e40693..fd7cc56 100644
> --- a/drivers/spi/spi-atmel.c
> +++ b/drivers/spi/spi-atmel.c
> @@ -629,9 +629,9 @@ static int atmel_spi_next_xfer_dma_submit(struct spi_master *master,
>  		goto err_dma;
>  
>  	dev_dbg(master->dev.parent,
> -		"  start dma xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> -		xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> -		xfer->rx_buf, xfer->rx_dma);
> +		"  start dma xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> +		xfer, xfer->len, xfer->tx_buf, (unsigned long long)xfer->tx_dma,
> +		xfer->rx_buf, (unsigned long long)xfer->rx_dma);
>  
>  	/* Enable relevant interrupts */
>  	spi_writel(as, IER, SPI_BIT(OVRES));
> @@ -732,9 +732,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
>  		spi_writel(as, TCR, len);
>  
>  		dev_dbg(&msg->spi->dev,
> -			"  start xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> -			xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> -			xfer->rx_buf, xfer->rx_dma);
> +			"  start xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> +			xfer, xfer->len, xfer->tx_buf,
> +			(unsigned long long)xfer->tx_dma, xfer->rx_buf,
> +			(unsigned long long)xfer->rx_dma);
>  	} else {
>  		xfer = as->next_transfer;
>  		remaining = as->next_remaining_bytes;
> @@ -771,9 +772,10 @@ static void atmel_spi_pdc_next_xfer(struct spi_master *master,
>  		spi_writel(as, TNCR, len);
>  
>  		dev_dbg(&msg->spi->dev,
> -			"  next xfer %p: len %u tx %p/%08x rx %p/%08x\n",
> -			xfer, xfer->len, xfer->tx_buf, xfer->tx_dma,
> -			xfer->rx_buf, xfer->rx_dma);
> +			"  next xfer %p: len %u tx %p/%08llx rx %p/%08llx\n",
> +			xfer, xfer->len, xfer->tx_buf,
> +			(unsigned long long)xfer->tx_dma, xfer->rx_buf,
> +			(unsigned long long)xfer->rx_dma);
>  		ieval = SPI_BIT(ENDRX) | SPI_BIT(OVRES);
>  	} else {
>  		spi_writel(as, RNCR, 0);

  reply	other threads:[~2013-07-31  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 17:35 [PATCH 1/3] spi/spi-atmel: Fix format specifier warnings Emil Goode
2013-07-31  8:16 ` walter harms [this message]
2013-07-31  8:23 ` Dan Carpenter
2013-07-31 16:55 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F8C7FB.6070601@bfs.de \
    --to=wharms@bfs.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.