From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39921)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6NX0-0000Xn-4m
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6NWq-00014W-3F
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:21:14 -0400
Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:44847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1V6NWp-00014P-Sy
	for qemu-devel@nongnu.org; Mon, 05 Aug 2013 12:21:04 -0400
Received: by mail-we0-f174.google.com with SMTP id q54so2618495wes.5
	for <qemu-devel@nongnu.org>; Mon, 05 Aug 2013 09:21:02 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <51FFD0EA.6040606@redhat.com>
Date: Mon, 05 Aug 2013 18:20:58 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1375014954-31916-1-git-send-email-pbonzini@redhat.com>
	<51FFC24C.6010300@terremark.com>
In-Reply-To: <51FFC24C.6010300@terremark.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.6] memory: add tracepoints for MMIO
	reads/writes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Don Slutz <dslutz@verizon.com>
Cc: qemu-devel@nongnu.org

On 08/05/2013 05:18 PM, Don Slutz wrote:
>> diff --git a/trace-events b/trace-events
>> index 002df83..3e0dd74 100644
>> --- a/trace-events
>> +++ b/trace-events
>> @@ -1165,6 +1165,10 @@ kvm_vm_ioctl(int type, void *arg) "type %d, arg
>> %p"
>>   kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d,
>> type %d, arg %p"
>>   kvm_run_exit(int cpu_index, uint32_t reason) "cpu_index %d, reason %d"
>> +# memory.c
>> +memory_region_ops_read(void *mr, uint64_t addr, uint64_t value,
>> unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>> +memory_region_ops_write(void *mr, uint64_t addr, uint64_t value,
>> unsigned size) "mr %p addr %#"PRIx64" value %#"PRIx64" size %d"
>> +
> Sorry about the late mail.  Did you mean to have the stderr trace text
> to be the same?

Yes, the name of the tracepoint should come before the text.

See scripts/tracetool/backend/stderr.py for the generator source code.

Paolo