From: "Andreas Färber" <afaerber@suse.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.6 v2 2/2] pci-bridge: Move common class initializations to base type
Date: Mon, 05 Aug 2013 18:22:18 +0200 [thread overview]
Message-ID: <51FFD13A.3000800@suse.de> (raw)
In-Reply-To: <51FFB98E.4020207@redhat.com>
Am 05.08.2013 16:41, schrieb Paolo Bonzini:
> On 08/05/2013 04:36 PM, Andreas Färber wrote:
>> Set PCIDeviceClass::is_bridge as well as PCIDeviceClass::config_write(),
>> PCIDeviceClass::exit() and DeviceClass::reset() defaults directly for
>> TYPE_PCI_BRIDGE (complements f055e96bd4311d287c0e03faec02a1bdbc351925).
>>
>> This avoids another pci_bridge_config_write() missing somewhere, unless
>> explicitly overridden.
>>
>> Reported-by: Gerd Hoffmann <kraxel@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>
> Why for 1.6?
This is The Real Fix. We could squash it as one patch, but then we can't
backport it.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-08-05 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 14:36 [Qemu-devel] [PATCH for-1.6 v2 0/2] PCI bridge fixes and cleanup Andreas Färber
2013-08-05 14:36 ` [Qemu-devel] [PATCH for-1.6 v2 1/2] i82801b11: Fix i82801b11 PCI host bridge config space Andreas Färber
2013-08-05 15:37 ` Michael S. Tsirkin
2013-08-12 8:51 ` Gerd Hoffmann
2013-08-12 8:53 ` Andreas Färber
2013-08-05 14:36 ` [Qemu-devel] [PATCH for-1.6 v2 2/2] pci-bridge: Move common class initializations to base type Andreas Färber
2013-08-05 14:41 ` Paolo Bonzini
2013-08-05 16:22 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FFD13A.3000800@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.