From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688ABC433F5 for ; Fri, 28 Jan 2022 06:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346508AbiA1G3R (ORCPT ); Fri, 28 Jan 2022 01:29:17 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:59108 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242495AbiA1G3G (ORCPT ); Fri, 28 Jan 2022 01:29:06 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7D31C21101; Fri, 28 Jan 2022 06:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1643351345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xpapT37KcxaYOeeQYt+sGcIsazRv7BTtatupftedrF0=; b=jOIkTwXv8I/BNPcVaUZMccPLMdv7gYAcODw3KAsgpoZi3HbCyu+UzuoaCrgTBTfUx7RO6a 8G/7Z0FRbD8ncn4CZQRF+hNelwTjHKj+i2xzIqSBSgj6N167UPwE9wW2Eo0PNRBY1WYPs1 9STYjKzmKUvIKQhu8dhmgZszLhJQWFc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1643351345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xpapT37KcxaYOeeQYt+sGcIsazRv7BTtatupftedrF0=; b=fRLo7kpURe7NYcJahmFg5gZfZCivitQUKm75iwXxaJJ0+gRNvm0D8C6fTOQJzVSDlIViri seKhrDL40QzkXKDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6DA0F13780; Fri, 28 Jan 2022 06:29:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QYCPGjGN82G3MQAAMHmgww (envelope-from ); Fri, 28 Jan 2022 06:29:05 +0000 MIME-Version: 1.0 Date: Fri, 28 Jan 2022 07:29:05 +0100 From: Oscar Salvador To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, LKML , David Hildenbrand , Alexey Makhalov , Dennis Zhou , Eric Dumazet , Tejun Heo , Christoph Lameter , Nico Pache , Wei Yang , Rafael Aquini , Michal Hocko Subject: Re: [PATCH 3/6] mm, memory_hotplug: drop arch_free_nodedata In-Reply-To: <20220127085305.20890-4-mhocko@kernel.org> References: <20220127085305.20890-1-mhocko@kernel.org> <20220127085305.20890-4-mhocko@kernel.org> User-Agent: Roundcube Webmail Message-ID: <51a7daf7815d000ac0fdb57755a054b2@suse.de> X-Sender: osalvador@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-01-27 09:53, Michal Hocko wrote: > From: Michal Hocko > > Prior to "mm: handle uninitialized numa nodes gracefully" memory > hotplug > used to allocate pgdat when memory has been added to a node > (hotadd_init_pgdat) arch_free_nodedata has been only used in the > failure path because once the pgdat is exported (to be visible > by NODA_DATA(nid)) it cannot really be freed because there is no > synchronization available for that. > > pgdat is allocated for each possible nodes now so the memory hotplug > doesn't need to do the ever use arch_free_nodedata so drop it. > > This patch doesn't introduce any functional change. > > Acked-by: Rafael Aquini > Signed-off-by: Michal Hocko Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs