All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
@ 2022-08-15 12:25 ` Allen-KH Cheng
  0 siblings, 0 replies; 6+ messages in thread
From: Allen-KH Cheng @ 2022-08-15 12:25 UTC (permalink / raw)
  To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Allen-KH Cheng,
	Guodong Liu

There are 8 GPIO physical address bases in mt8186, corresponding to the
items of 'reg-names' with the pinctrl driver. but the order of
'reg-names' is not correct. The mt8186 pinctrl driver would get the
wrong address, causing the system to restart when regulator initializes
. we fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
in bindings.

Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
---
 .../bindings/pinctrl/pinctrl-mt8186.yaml         | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 1eeb885ce0c6..604445e390a7 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -41,12 +41,12 @@ properties:
       Gpio base register names.
     items:
       - const: iocfg0
-      - const: iocfg_bm
-      - const: iocfg_bl
-      - const: iocfg_br
+      - const: iocfg_lt
       - const: iocfg_lm
+      - const: iocfg_lb
+      - const: iocfg_bl
       - const: iocfg_rb
-      - const: iocfg_tl
+      - const: iocfg_rt
       - const: eint
 
   interrupt-controller: true
@@ -232,12 +232,12 @@ examples:
             <0x10002200 0x0200>,
             <0x10002400 0x0200>,
             <0x10002600 0x0200>,
-            <0x10002A00 0x0200>,
+            <0x10002a00 0x0200>,
             <0x10002c00 0x0200>,
             <0x1000b000 0x1000>;
-      reg-names = "iocfg0", "iocfg_bm", "iocfg_bl",
-                  "iocfg_br", "iocfg_lm", "iocfg_rb",
-                  "iocfg_tl", "eint";
+      reg-names = "iocfg0", "iocfg_lt", "iocfg_lm",
+                  "iocfg_lb", "iocfg_bl", "iocfg_rb",
+                  "iocfg_rt", "eint";
       gpio-controller;
       #gpio-cells = <2>;
       gpio-ranges = <&pio 0 0 185>;
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
@ 2022-08-15 12:25 ` Allen-KH Cheng
  0 siblings, 0 replies; 6+ messages in thread
From: Allen-KH Cheng @ 2022-08-15 12:25 UTC (permalink / raw)
  To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Allen-KH Cheng,
	Guodong Liu

There are 8 GPIO physical address bases in mt8186, corresponding to the
items of 'reg-names' with the pinctrl driver. but the order of
'reg-names' is not correct. The mt8186 pinctrl driver would get the
wrong address, causing the system to restart when regulator initializes
. we fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
in bindings.

Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
---
 .../bindings/pinctrl/pinctrl-mt8186.yaml         | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
index 1eeb885ce0c6..604445e390a7 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8186.yaml
@@ -41,12 +41,12 @@ properties:
       Gpio base register names.
     items:
       - const: iocfg0
-      - const: iocfg_bm
-      - const: iocfg_bl
-      - const: iocfg_br
+      - const: iocfg_lt
       - const: iocfg_lm
+      - const: iocfg_lb
+      - const: iocfg_bl
       - const: iocfg_rb
-      - const: iocfg_tl
+      - const: iocfg_rt
       - const: eint
 
   interrupt-controller: true
@@ -232,12 +232,12 @@ examples:
             <0x10002200 0x0200>,
             <0x10002400 0x0200>,
             <0x10002600 0x0200>,
-            <0x10002A00 0x0200>,
+            <0x10002a00 0x0200>,
             <0x10002c00 0x0200>,
             <0x1000b000 0x1000>;
-      reg-names = "iocfg0", "iocfg_bm", "iocfg_bl",
-                  "iocfg_br", "iocfg_lm", "iocfg_rb",
-                  "iocfg_tl", "eint";
+      reg-names = "iocfg0", "iocfg_lt", "iocfg_lm",
+                  "iocfg_lb", "iocfg_bl", "iocfg_rb",
+                  "iocfg_rt", "eint";
       gpio-controller;
       #gpio-cells = <2>;
       gpio-ranges = <&pio 0 0 185>;
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
  2022-08-15 12:25 ` Allen-KH Cheng
@ 2022-08-16  7:14   ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-16  7:14 UTC (permalink / raw)
  To: Allen-KH Cheng, Linus Walleij, Rob Herring, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Guodong Liu

On 15/08/2022 15:25, Allen-KH Cheng wrote:
> There are 8 GPIO physical address bases in mt8186, corresponding to the
> items of 'reg-names' with the pinctrl driver. but the order of

New sentences start with capital letter.

> 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> wrong address, causing the system to restart when regulator initializes
> . we 

^^^ Something is missing. Sentence looks unfinished, full stop is in new
line, next sentence does not start with capital letter.


> fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> in bindings.
> 
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> ---
Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
@ 2022-08-16  7:14   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-16  7:14 UTC (permalink / raw)
  To: Allen-KH Cheng, Linus Walleij, Rob Herring, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Guodong Liu

On 15/08/2022 15:25, Allen-KH Cheng wrote:
> There are 8 GPIO physical address bases in mt8186, corresponding to the
> items of 'reg-names' with the pinctrl driver. but the order of

New sentences start with capital letter.

> 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> wrong address, causing the system to restart when regulator initializes
> . we 

^^^ Something is missing. Sentence looks unfinished, full stop is in new
line, next sentence does not start with capital letter.


> fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> in bindings.
> 
> Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl file and binding document")
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> ---
Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
  2022-08-16  7:14   ` Krzysztof Kozlowski
@ 2022-08-16 12:55     ` Allen-KH Cheng
  -1 siblings, 0 replies; 6+ messages in thread
From: Allen-KH Cheng @ 2022-08-16 12:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Linus Walleij, Rob Herring, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Guodong Liu

Hi Krzysztof,

On Tue, 2022-08-16 at 10:14 +0300, Krzysztof Kozlowski wrote:
> On 15/08/2022 15:25, Allen-KH Cheng wrote:
> > There are 8 GPIO physical address bases in mt8186, corresponding to
> > the
> > items of 'reg-names' with the pinctrl driver. but the order of
> 
> New sentences start with capital letter.
> 
> > 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> > wrong address, causing the system to restart when regulator
> > initializes
> > . we 
> 
> ^^^ Something is missing. Sentence looks unfinished, full stop is in
> new
> line, next sentence does not start with capital letter.
> 
> 

Thanks for your kind reminder.
I'll update in the next version.

Best regards,
Allen

> > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> > in bindings.
> > 
> > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl
> > file and binding document")
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> > ---
> 
> Best regards,
> Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes
@ 2022-08-16 12:55     ` Allen-KH Cheng
  0 siblings, 0 replies; 6+ messages in thread
From: Allen-KH Cheng @ 2022-08-16 12:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Linus Walleij, Rob Herring, Matthias Brugger
  Cc: Project_Global_Chrome_Upstream_Group, devicetree,
	linux-arm-kernel, linux-kernel, linux-mediatek, Guodong Liu

Hi Krzysztof,

On Tue, 2022-08-16 at 10:14 +0300, Krzysztof Kozlowski wrote:
> On 15/08/2022 15:25, Allen-KH Cheng wrote:
> > There are 8 GPIO physical address bases in mt8186, corresponding to
> > the
> > items of 'reg-names' with the pinctrl driver. but the order of
> 
> New sentences start with capital letter.
> 
> > 'reg-names' is not correct. The mt8186 pinctrl driver would get the
> > wrong address, causing the system to restart when regulator
> > initializes
> > . we 
> 
> ^^^ Something is missing. Sentence looks unfinished, full stop is in
> new
> line, next sentence does not start with capital letter.
> 
> 

Thanks for your kind reminder.
I'll update in the next version.

Best regards,
Allen

> > fix 'reg-names' for pinctrl nodes and the pinctrl-mt8186 example
> > in bindings.
> > 
> > Fixes: 338e953f1bd1 ("dt-bindings: pinctrl: mt8186: add pinctrl
> > file and binding document")
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
> > ---
> 
> Best regards,
> Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-16 13:57 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 12:25 [PATCH] dt-bindings: pinctrl: mt8186: Fix 'reg-names' for pinctrl nodes Allen-KH Cheng
2022-08-15 12:25 ` Allen-KH Cheng
2022-08-16  7:14 ` Krzysztof Kozlowski
2022-08-16  7:14   ` Krzysztof Kozlowski
2022-08-16 12:55   ` Allen-KH Cheng
2022-08-16 12:55     ` Allen-KH Cheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.