From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56455) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0lCk-0003Xf-K6 for qemu-devel@nongnu.org; Wed, 19 Apr 2017 04:43:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0lCg-0001rO-Rv for qemu-devel@nongnu.org; Wed, 19 Apr 2017 04:43:14 -0400 Received: from smtp.eu.citrix.com ([185.25.65.24]:12713) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0lCg-0001q8-J1 for qemu-devel@nongnu.org; Wed, 19 Apr 2017 04:43:10 -0400 From: Paul Durrant Date: Wed, 19 Apr 2017 08:43:05 +0000 Message-ID: <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Stefano Stabellini' Cc: "qemu-devel@nongnu.org" , Anthony Perard , Wei Liu , "jgross@suse.com" , "julien.grall@arm.com" , "xen-devel@lists.xenproject.org" > -----Original Message----- > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > Sent: 18 April 2017 18:41 > To: Paul Durrant > Cc: 'Stefano Stabellini' ; qemu-devel@nongnu.org; > Anthony Perard ; Wei Liu > ; jgross@suse.com; julien.grall@arm.com; xen- > devel@lists.xenproject.org > Subject: RE: QEMU build breakage on ARM against Xen 4.9 caused by > libxendevicemodel >=20 > On Tue, 18 Apr 2017, Paul Durrant wrote: > > > -----Original Message----- > > > From: Stefano Stabellini [mailto:sstabellini@kernel.org] > > > Sent: 15 April 2017 01:40 > > > To: Stefano Stabellini > > > Cc: Paul Durrant ; qemu-devel@nongnu.org; > > > Anthony Perard ; Wei Liu > > > ; jgross@suse.com; julien.grall@arm.com; xen- > > > devel@lists.xenproject.org > > > Subject: Re: QEMU build breakage on ARM against Xen 4.9 caused by > > > libxendevicemodel > > > > > > On Fri, 14 Apr 2017, Stefano Stabellini wrote: > > > > Hi Paul, > > > > > > > > The following commit in my qemu "next" branch breaks the build on > arm > > > > and arm64: > > > > > > > > commit 670271647ad15e9d937ced7a72c892349c709216 > > > > Author: Paul Durrant > > > > Date: Tue Mar 7 10:55:34 2017 +0000 > > > > > > > > xen: use libxendevicemodel when available > > > > > > > > See the appended build log. Sorry for not realizing it sooner. > > > > > > As I imagined, this bug is easy to solve. It is reproducible on x86 t= oo, > > > if you pass -DXC_WANT_COMPAT_DEVICEMODEL_API=3D1 to configure > and > > > forcefully disable Xen 4.9 detection in the configure script. > > > > > > If QEMU detects xen_ctrl_version =3D 480, the build will fail against= Xen > > > 4.9, even when -DXC_WANT_COMPAT_DEVICEMODEL_API=3D1 is > specified. > > > > > > The appended patch solves the problem. However, Xen 4.9 detection > and > > > compilation remain broken. > > > > Ok, that fix looks fine to me. >=20 > I merged this change into "use libxendevicemodel when available" in my > next branch. >=20 > Are you going to take care of getting the QEMU build on ARM to work > against Xen 4.9 (properly detecting 4.9, without > -DXC_WANT_COMPAT_DEVICEMODEL_API=3D1)? >=20 I can take a look once I get access to some h/w. Since the 4.9 detection sh= ould merely be based upon the presence of libxendevicemodel, I can't really= imagine why ARM should behave any differently to x86. Paul >=20 > > > > > > --- > > > > > > diff --git a/include/hw/xen/xen_common.h > > > b/include/hw/xen/xen_common.h > > > index 274accc..b1f5f53 100644 > > > --- a/include/hw/xen/xen_common.h > > > +++ b/include/hw/xen/xen_common.h > > > @@ -9,7 +9,6 @@ > > > #undef XC_WANT_COMPAT_EVTCHN_API > > > #undef XC_WANT_COMPAT_GNTTAB_API > > > #undef XC_WANT_COMPAT_MAP_FOREIGN_API > > > -#undef XC_WANT_COMPAT_DEVICEMODEL_API > > > > > > #include > > > #include > > > @@ -154,6 +153,7 @@ static inline int xendevicemodel_set_mem_type( > > > > > > #else /* CONFIG_XEN_CTRL_INTERFACE_VERSION >=3D 490 */ > > > > > > +#undef XC_WANT_COMPAT_DEVICEMODEL_API > > > #include > > > > > > #endif > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel Date: Wed, 19 Apr 2017 08:43:05 +0000 Message-ID: <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0lCe-0001p0-OQ for xen-devel@lists.xenproject.org; Wed, 19 Apr 2017 08:43:08 +0000 In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: 'Stefano Stabellini' Cc: "jgross@suse.com" , Wei Liu , "qemu-devel@nongnu.org" , "julien.grall@arm.com" , Anthony Perard , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IFN0ZWZhbm8gU3RhYmVsbGluaSBb bWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmddCj4gU2VudDogMTggQXByaWwgMjAxNyAxODo0 MQo+IFRvOiBQYXVsIER1cnJhbnQgPFBhdWwuRHVycmFudEBjaXRyaXguY29tPgo+IENjOiAnU3Rl ZmFubyBTdGFiZWxsaW5pJyA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IHFlbXUtZGV2ZWxAbm9u Z251Lm9yZzsKPiBBbnRob255IFBlcmFyZCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47IFdl aSBMaXUKPiA8d2VpLmxpdTJAY2l0cml4LmNvbT47IGpncm9zc0BzdXNlLmNvbTsganVsaWVuLmdy YWxsQGFybS5jb207IHhlbi0KPiBkZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwo+IFN1YmplY3Q6 IFJFOiBRRU1VIGJ1aWxkIGJyZWFrYWdlIG9uIEFSTSBhZ2FpbnN0IFhlbiA0LjkgY2F1c2VkIGJ5 Cj4gbGlieGVuZGV2aWNlbW9kZWwKPiAKPiBPbiBUdWUsIDE4IEFwciAyMDE3LCBQYXVsIER1cnJh bnQgd3JvdGU6Cj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tCj4gPiA+IEZyb206IFN0 ZWZhbm8gU3RhYmVsbGluaSBbbWFpbHRvOnNzdGFiZWxsaW5pQGtlcm5lbC5vcmddCj4gPiA+IFNl bnQ6IDE1IEFwcmlsIDIwMTcgMDE6NDAKPiA+ID4gVG86IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz4KPiA+ID4gQ2M6IFBhdWwgRHVycmFudCA8UGF1bC5EdXJyYW50 QGNpdHJpeC5jb20+OyBxZW11LWRldmVsQG5vbmdudS5vcmc7Cj4gPiA+IEFudGhvbnkgUGVyYXJk IDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPjsgV2VpIExpdQo+ID4gPiA8d2VpLmxpdTJAY2l0 cml4LmNvbT47IGpncm9zc0BzdXNlLmNvbTsganVsaWVuLmdyYWxsQGFybS5jb207IHhlbi0KPiA+ ID4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKPiA+ID4gU3ViamVjdDogUmU6IFFFTVUgYnVp bGQgYnJlYWthZ2Ugb24gQVJNIGFnYWluc3QgWGVuIDQuOSBjYXVzZWQgYnkKPiA+ID4gbGlieGVu ZGV2aWNlbW9kZWwKPiA+ID4KPiA+ID4gT24gRnJpLCAxNCBBcHIgMjAxNywgU3RlZmFubyBTdGFi ZWxsaW5pIHdyb3RlOgo+ID4gPiA+IEhpIFBhdWwsCj4gPiA+ID4KPiA+ID4gPiBUaGUgZm9sbG93 aW5nIGNvbW1pdCBpbiBteSBxZW11ICJuZXh0IiBicmFuY2ggYnJlYWtzIHRoZSBidWlsZCBvbgo+ IGFybQo+ID4gPiA+IGFuZCBhcm02NDoKPiA+ID4gPgo+ID4gPiA+IGNvbW1pdCA2NzAyNzE2NDdh ZDE1ZTlkOTM3Y2VkN2E3MmM4OTIzNDljNzA5MjE2Cj4gPiA+ID4gQXV0aG9yOiBQYXVsIER1cnJh bnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPgo+ID4gPiA+IERhdGU6ICAgVHVlIE1hciA3IDEw OjU1OjM0IDIwMTcgKzAwMDAKPiA+ID4gPgo+ID4gPiA+ICAgICB4ZW46IHVzZSBsaWJ4ZW5kZXZp Y2Vtb2RlbCB3aGVuIGF2YWlsYWJsZQo+ID4gPiA+Cj4gPiA+ID4gU2VlIHRoZSBhcHBlbmRlZCBi dWlsZCBsb2cuIFNvcnJ5IGZvciBub3QgcmVhbGl6aW5nIGl0IHNvb25lci4KPiA+ID4KPiA+ID4g QXMgSSBpbWFnaW5lZCwgdGhpcyBidWcgaXMgZWFzeSB0byBzb2x2ZS4gSXQgaXMgcmVwcm9kdWNp YmxlIG9uIHg4NiB0b28sCj4gPiA+IGlmIHlvdSBwYXNzIC1EWENfV0FOVF9DT01QQVRfREVWSUNF TU9ERUxfQVBJPTEgdG8gY29uZmlndXJlCj4gYW5kCj4gPiA+IGZvcmNlZnVsbHkgZGlzYWJsZSBY ZW4gNC45IGRldGVjdGlvbiBpbiB0aGUgY29uZmlndXJlIHNjcmlwdC4KPiA+ID4KPiA+ID4gSWYg UUVNVSBkZXRlY3RzIHhlbl9jdHJsX3ZlcnNpb24gPSA0ODAsIHRoZSBidWlsZCB3aWxsIGZhaWwg YWdhaW5zdCBYZW4KPiA+ID4gNC45LCBldmVuIHdoZW4gLURYQ19XQU5UX0NPTVBBVF9ERVZJQ0VN T0RFTF9BUEk9MSBpcwo+IHNwZWNpZmllZC4KPiA+ID4KPiA+ID4gVGhlIGFwcGVuZGVkIHBhdGNo IHNvbHZlcyB0aGUgcHJvYmxlbS4gSG93ZXZlciwgWGVuIDQuOSBkZXRlY3Rpb24KPiBhbmQKPiA+ ID4gY29tcGlsYXRpb24gcmVtYWluIGJyb2tlbi4KPiA+Cj4gPiBPaywgdGhhdCBmaXggbG9va3Mg ZmluZSB0byBtZS4KPiAKPiBJIG1lcmdlZCB0aGlzIGNoYW5nZSBpbnRvICJ1c2UgbGlieGVuZGV2 aWNlbW9kZWwgd2hlbiBhdmFpbGFibGUiIGluIG15Cj4gbmV4dCBicmFuY2guCj4gCj4gQXJlIHlv dSBnb2luZyB0byB0YWtlIGNhcmUgb2YgZ2V0dGluZyB0aGUgUUVNVSBidWlsZCBvbiBBUk0gdG8g d29yawo+IGFnYWluc3QgWGVuIDQuOSAocHJvcGVybHkgZGV0ZWN0aW5nIDQuOSwgd2l0aG91dAo+ IC1EWENfV0FOVF9DT01QQVRfREVWSUNFTU9ERUxfQVBJPTEpPwo+IAoKSSBjYW4gdGFrZSBhIGxv b2sgb25jZSBJIGdldCBhY2Nlc3MgdG8gc29tZSBoL3cuIFNpbmNlIHRoZSA0LjkgZGV0ZWN0aW9u IHNob3VsZCBtZXJlbHkgYmUgYmFzZWQgdXBvbiB0aGUgcHJlc2VuY2Ugb2YgbGlieGVuZGV2aWNl bW9kZWwsIEkgY2FuJ3QgcmVhbGx5IGltYWdpbmUgd2h5IEFSTSBzaG91bGQgYmVoYXZlIGFueSBk aWZmZXJlbnRseSB0byB4ODYuCgogIFBhdWwKCj4gCj4gPiA+Cj4gPiA+IC0tLQo+ID4gPgo+ID4g PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9ody94ZW4veGVuX2NvbW1vbi5oCj4gPiA+IGIvaW5jbHVk ZS9ody94ZW4veGVuX2NvbW1vbi5oCj4gPiA+IGluZGV4IDI3NGFjY2MuLmIxZjVmNTMgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2luY2x1ZGUvaHcveGVuL3hlbl9jb21tb24uaAo+ID4gPiArKysgYi9pbmNs dWRlL2h3L3hlbi94ZW5fY29tbW9uLmgKPiA+ID4gQEAgLTksNyArOSw2IEBACj4gPiA+ICAjdW5k ZWYgWENfV0FOVF9DT01QQVRfRVZUQ0hOX0FQSQo+ID4gPiAgI3VuZGVmIFhDX1dBTlRfQ09NUEFU X0dOVFRBQl9BUEkKPiA+ID4gICN1bmRlZiBYQ19XQU5UX0NPTVBBVF9NQVBfRk9SRUlHTl9BUEkK PiA+ID4gLSN1bmRlZiBYQ19XQU5UX0NPTVBBVF9ERVZJQ0VNT0RFTF9BUEkKPiA+ID4KPiA+ID4g ICNpbmNsdWRlIDx4ZW5jdHJsLmg+Cj4gPiA+ICAjaW5jbHVkZSA8eGVuc3RvcmUuaD4KPiA+ID4g QEAgLTE1NCw2ICsxNTMsNyBAQCBzdGF0aWMgaW5saW5lIGludCB4ZW5kZXZpY2Vtb2RlbF9zZXRf bWVtX3R5cGUoCj4gPiA+Cj4gPiA+ICAjZWxzZSAvKiBDT05GSUdfWEVOX0NUUkxfSU5URVJGQUNF X1ZFUlNJT04gPj0gNDkwICovCj4gPiA+Cj4gPiA+ICsjdW5kZWYgWENfV0FOVF9DT01QQVRfREVW SUNFTU9ERUxfQVBJCj4gPiA+ICAjaW5jbHVkZSA8eGVuZGV2aWNlbW9kZWwuaD4KPiA+ID4KPiA+ ID4gICNlbmRpZgo+ID4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0 cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=