* [PATCH for-next] RDMA/hns: Fix incorrect lsn field
@ 2021-06-22 12:00 Weihang Li
2021-06-22 12:24 ` liweihang
0 siblings, 1 reply; 2+ messages in thread
From: Weihang Li @ 2021-06-22 12:00 UTC (permalink / raw)
To: dledford, jgg; +Cc: leon, linux-rdma, linuxarm, Yixing Liu, Weihang Li
From: Yixing Liu <liuyixing1@huawei.com>
In RNR NAK screnario, according to the specification, when no credit is
available, only the first fragment of the send request can be sent. The
LSN(Limit Sequence Number) field should be 0 or the entire packet will be
resent.
Fixes: f0cb411aad23 ("RDMA/hns: Use new interface to modify QP context")
Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
Signed-off-by: Weihang Li <liweihang@huawei.com>
---
drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
index 069c7cd..7da2a74 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
@@ -4515,7 +4515,6 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp,
hr_reg_clear(qpc_mask, QPC_CHECK_FLG);
- hr_reg_write(context, QPC_LSN, 0x100);
hr_reg_clear(qpc_mask, QPC_LSN);
hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-next] RDMA/hns: Fix incorrect lsn field
2021-06-22 12:00 [PATCH for-next] RDMA/hns: Fix incorrect lsn field Weihang Li
@ 2021-06-22 12:24 ` liweihang
0 siblings, 0 replies; 2+ messages in thread
From: liweihang @ 2021-06-22 12:24 UTC (permalink / raw)
To: dledford, jgg; +Cc: leon, linux-rdma, Linuxarm, liuyixing (A)
On 2021/6/22 20:01, liweihang wrote:
> From: Yixing Liu <liuyixing1@huawei.com>
>
> In RNR NAK screnario, according to the specification, when no credit is
> available, only the first fragment of the send request can be sent. The
> LSN(Limit Sequence Number) field should be 0 or the entire packet will be
> resent.
>
> Fixes: f0cb411aad23 ("RDMA/hns: Use new interface to modify QP context")
> Signed-off-by: Yixing Liu <liuyixing1@huawei.com>
> Signed-off-by: Weihang Li <liweihang@huawei.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 069c7cd..7da2a74 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -4515,7 +4515,6 @@ static int modify_qp_rtr_to_rts(struct ib_qp *ibqp,
>
> hr_reg_clear(qpc_mask, QPC_CHECK_FLG);
>
> - hr_reg_write(context, QPC_LSN, 0x100);
> hr_reg_clear(qpc_mask, QPC_LSN);
>
This hr_reg_clear() is redundant and needs to be removed. I will resend this patch.
Weihang
> hr_reg_clear(qpc_mask, QPC_V2_IRRL_HEAD);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-22 12:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 12:00 [PATCH for-next] RDMA/hns: Fix incorrect lsn field Weihang Li
2021-06-22 12:24 ` liweihang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.