From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF5FEC64EC7 for ; Tue, 21 Feb 2023 17:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231675AbjBUR6l (ORCPT ); Tue, 21 Feb 2023 12:58:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232254AbjBUR6i (ORCPT ); Tue, 21 Feb 2023 12:58:38 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 772522F785 for ; Tue, 21 Feb 2023 09:58:35 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id j2so5208627wrh.9 for ; Tue, 21 Feb 2023 09:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S9iW/ZoFwA+vNVbz0hgRVCmhSYJ67As/r6GQ/C1MS14=; b=kkmL3bkoMHa3rpgJXIU9fm2m/Fc9fjZpTR1+czz9opAjVjbwio3hmu13RUzThMYSXr dAX9XP9ZETJTtBG/QfX7MLtnF0j7iNoZ+6VR48IL6eY1Uw/Rb2J3XMlPIbrCbU7JbcJm 5sE1pZjBk+SnC1hEpL2huMoX5Okevrj7K/cC8lPGfxtmEFmCVIJDnloBCXlpxCBZPGQD eEyXAU8spQI6HN5l7w6WeCddUq9Hfo3j+p2R/paxWwsuumVe1yo+tgc+axra5TILoAEa z/nbx6Ycfgg1nU3Zd1TPZpREwMdRh1wGGq5ltq59Q/PgXdHcnvnLjZX2fUdWRvnsBDF9 3iHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9iW/ZoFwA+vNVbz0hgRVCmhSYJ67As/r6GQ/C1MS14=; b=TYD3d2zFVWm4kjiAhyg7LroLHPTwujFlyL2Pw0OBTbbhXnQe0w435Pb0JaVXrDkUjM fUTSYvIIYijiyz4VwGWMyr4t2U67hXrKwpv9k+MTBNSM+WehlZnUjYqDkenkhY4fSQXq LTNWSZaPxOQQng44J4RihoHZjTOItzSVbyfBy+uUoLoi0AB0ExFQGCgZF5smynfIlp6K aBxPj3NgSdn+KaHA1VUEx5m0bf3faV5PfdxrdNM208xmFg8JgCq5O7AMn+vRIiMmuYWI ngIvwouQoK1j5NKf2wzaR7fiYLZh6SrVzbbDRA3IZbVJMIL0bTuTPGkatYoqKZ/l/Lat V1kA== X-Gm-Message-State: AO0yUKXGyJAm49MucgUjscype16tRvELfhcHlj2lSvhr692d7ss/I/ce qOyf9Z2MNUXVorSpOiiz1M77bg== X-Google-Smtp-Source: AK7set+2VYBIviYYpXRgHb6iWH4/F+lDyppvQ+R3fLX/zzCucj88ZsetqCFcBEokjGqacqiFHlxYlQ== X-Received: by 2002:adf:d081:0:b0:2c5:9a0d:70a2 with SMTP id y1-20020adfd081000000b002c59a0d70a2mr4778164wrh.16.1677002313874; Tue, 21 Feb 2023 09:58:33 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id z8-20020a056000110800b002c3dc4131f5sm6101436wrw.18.2023.02.21.09.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 09:58:33 -0800 (PST) Message-ID: <51b57a36-a1e0-45c4-7300-6d2a85f30f6d@linaro.org> Date: Tue, 21 Feb 2023 17:58:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 19/26] gunyah: vm_mgr: Add framework to add VM Functions Content-Language: en-US To: Srivatsa Vaddagiri , Elliot Berman Cc: Alex Elder , Prakruthi Deepak Heragu , Jonathan Corbet , Murali Nalajala , Trilok Soni , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212531.3323284-1-quic_eberman@quicinc.com> <20230221130759.GD787573@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <20230221130759.GD787573@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 21/02/2023 13:07, Srivatsa Vaddagiri wrote: > * Elliot Berman [2023-02-14 13:25:30]: > >> +int __must_check gh_vm_get(struct gh_vm *ghvm) > > Minor comment: > > get_gh_rm vs gh_vm_get -> can follow some consistent convention I think. > > Perhaps get_gh_vm()? it should be other way around currently we have combinations of gh_vm and some other pattern, we should stick with one, in this case gh_vm_* or gh_rm_* makes more sense here are all the exported symbols in gunyah. ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_function_register); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_function_unregister); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_add_resource_ticket); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_remove_resource_ticket); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_mmio_write); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_add_io_handler); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_remove_io_handler); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_get); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_put); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(gh_rm_notifier_register); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(gh_rm_notifier_unregister); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(get_gh_rm); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(put_gh_rm); ./drivers/virt/gunyah/gunyah.c:EXPORT_SYMBOL_GPL(gh_api_version); ./drivers/virt/gunyah/gunyah.c:EXPORT_SYMBOL_GPL(gh_api_has_feature); ./drivers/virt/gunyah/rsc_mgr_rpc.c:EXPORT_SYMBOL_GPL(gh_rm_get_vmid); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_platform_pre_mem_share); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_platform_post_mem_reclaim); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_register_platform_ops); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_unregister_platform_ops); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(devm_gh_rm_register_platform_ops); > > >> +{ >> + return kref_get_unless_zero(&ghvm->kref); >> +} >> +EXPORT_SYMBOL_GPL(gh_vm_get); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0861C636D7 for ; Tue, 21 Feb 2023 17:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9rko+O/D4M9E+lXptX9CJ8KzIR9poGr7J7p2GjT8A84=; b=2anNGdZvyYkazj 9LbfPGpRbieGSx+P1jN2ATcqqgb1s8dmNivVIsbJHRya4axIc6/3fQa4EoHAepPx7Vtnsh80OG/QY rSj+2bwgh3rDLvuhDLn1Ilj5vOozg3/uXFWsybHjg8iEYynr3TnTh1hCaoIQJ3Z4gxhSffjTQTNkJ 8PZRPLRJp+kN51C/kcDCUHPjZk2b9dcaj/3tubS6FzGpPgKI8Q4xErQDAWArD+w0F9tDAKqO9qOnm 4WjXFcoZu+qwLNbaa1p7szIW0ptNqPf0EJCdoOWRshUT/CZaSmf2iIpxjOMWqRfFk5FkkzYsLKU6s E3BMsAPRzw+X+xNNB0pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUWuY-009G1Q-8U; Tue, 21 Feb 2023 17:58:42 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pUWuT-009G0N-UF for linux-arm-kernel@lists.infradead.org; Tue, 21 Feb 2023 17:58:39 +0000 Received: by mail-wr1-x42f.google.com with SMTP id l1so5113653wry.10 for ; Tue, 21 Feb 2023 09:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S9iW/ZoFwA+vNVbz0hgRVCmhSYJ67As/r6GQ/C1MS14=; b=kkmL3bkoMHa3rpgJXIU9fm2m/Fc9fjZpTR1+czz9opAjVjbwio3hmu13RUzThMYSXr dAX9XP9ZETJTtBG/QfX7MLtnF0j7iNoZ+6VR48IL6eY1Uw/Rb2J3XMlPIbrCbU7JbcJm 5sE1pZjBk+SnC1hEpL2huMoX5Okevrj7K/cC8lPGfxtmEFmCVIJDnloBCXlpxCBZPGQD eEyXAU8spQI6HN5l7w6WeCddUq9Hfo3j+p2R/paxWwsuumVe1yo+tgc+axra5TILoAEa z/nbx6Ycfgg1nU3Zd1TPZpREwMdRh1wGGq5ltq59Q/PgXdHcnvnLjZX2fUdWRvnsBDF9 3iHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S9iW/ZoFwA+vNVbz0hgRVCmhSYJ67As/r6GQ/C1MS14=; b=xrDbz2pIwHzr60dLfkn4X2XRWRENV4uGnlRP198usSIcHrkLEUS+KaDyL49eBIIUYa 7HsD0HaE94L/1uDlJSKsajUliZ7FadDMGvw58f7HnIPkz9sWmNpeYuCbdnPUpeCT5nE3 yfDf6gYw8mvUagk5cRprJlbs+9uV4H8owZbiKwXnSPjfg9ZH0SsHkC+3sbia+3NdXEky pR0ZHMUOgq9ZnUN1PqLNhbDEhL+AD/SKosphhUzcYlirgZTUurll6Sl/8xX6MmyiA9pt kAMI1bn8CusJMXH8mKsLJ6NVZXUc+4acpgRBw3G/a+daYLu/HMHTy53Zvv7B3HIXP/4I 5w5A== X-Gm-Message-State: AO0yUKVNlH0MbHjOaO++0peK9N8wFhyh4VgJSfKEib0qwB2DZO4ZIkpI iqyYRUUaAj09Q4Glqt9qvvVk4Q== X-Google-Smtp-Source: AK7set+2VYBIviYYpXRgHb6iWH4/F+lDyppvQ+R3fLX/zzCucj88ZsetqCFcBEokjGqacqiFHlxYlQ== X-Received: by 2002:adf:d081:0:b0:2c5:9a0d:70a2 with SMTP id y1-20020adfd081000000b002c59a0d70a2mr4778164wrh.16.1677002313874; Tue, 21 Feb 2023 09:58:33 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id z8-20020a056000110800b002c3dc4131f5sm6101436wrw.18.2023.02.21.09.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Feb 2023 09:58:33 -0800 (PST) Message-ID: <51b57a36-a1e0-45c4-7300-6d2a85f30f6d@linaro.org> Date: Tue, 21 Feb 2023 17:58:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v10 19/26] gunyah: vm_mgr: Add framework to add VM Functions Content-Language: en-US To: Srivatsa Vaddagiri , Elliot Berman Cc: Alex Elder , Prakruthi Deepak Heragu , Jonathan Corbet , Murali Nalajala , Trilok Soni , Carl van Schaik , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Bagas Sanjaya , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230214211229.3239350-1-quic_eberman@quicinc.com> <20230214212531.3323284-1-quic_eberman@quicinc.com> <20230221130759.GD787573@quicinc.com> From: Srinivas Kandagatla In-Reply-To: <20230221130759.GD787573@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230221_095838_007778_75AEB346 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/02/2023 13:07, Srivatsa Vaddagiri wrote: > * Elliot Berman [2023-02-14 13:25:30]: > >> +int __must_check gh_vm_get(struct gh_vm *ghvm) > > Minor comment: > > get_gh_rm vs gh_vm_get -> can follow some consistent convention I think. > > Perhaps get_gh_vm()? it should be other way around currently we have combinations of gh_vm and some other pattern, we should stick with one, in this case gh_vm_* or gh_rm_* makes more sense here are all the exported symbols in gunyah. ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_function_register); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_function_unregister); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_add_resource_ticket); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_remove_resource_ticket); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_mmio_write); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_add_io_handler); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_remove_io_handler); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_get); ./drivers/virt/gunyah/vm_mgr.c:EXPORT_SYMBOL_GPL(gh_vm_put); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(gh_rm_notifier_register); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(gh_rm_notifier_unregister); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(get_gh_rm); ./drivers/virt/gunyah/rsc_mgr.c:EXPORT_SYMBOL_GPL(put_gh_rm); ./drivers/virt/gunyah/gunyah.c:EXPORT_SYMBOL_GPL(gh_api_version); ./drivers/virt/gunyah/gunyah.c:EXPORT_SYMBOL_GPL(gh_api_has_feature); ./drivers/virt/gunyah/rsc_mgr_rpc.c:EXPORT_SYMBOL_GPL(gh_rm_get_vmid); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_platform_pre_mem_share); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_platform_post_mem_reclaim); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_register_platform_ops); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(gh_rm_unregister_platform_ops); ./drivers/virt/gunyah/gunyah_platform_hooks.c:EXPORT_SYMBOL_GPL(devm_gh_rm_register_platform_ops); > > >> +{ >> + return kref_get_unless_zero(&ghvm->kref); >> +} >> +EXPORT_SYMBOL_GPL(gh_vm_get); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel