From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF4C0C11F64 for ; Thu, 1 Jul 2021 19:35:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 993B76140D for ; Thu, 1 Jul 2021 19:35:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233444AbhGATiD (ORCPT ); Thu, 1 Jul 2021 15:38:03 -0400 Received: from smtprelay0132.hostedemail.com ([216.40.44.132]:39464 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229894AbhGATiC (ORCPT ); Thu, 1 Jul 2021 15:38:02 -0400 Received: from omf06.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id C82ED182CF666; Thu, 1 Jul 2021 19:35:30 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA id 6CD962448B8; Thu, 1 Jul 2021 19:35:30 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 01 Jul 2021 12:35:29 -0700 From: Joe Perches To: Steven Rostedt Cc: Paul Burton , Joel Fernandes , linux-kernel@vger.kernel.org, Ingo Molnar , stable@vger.kernel.org Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic In-Reply-To: <20210701142624.44bb4dde@oasis.local.home> References: <20210630003406.4013668-1-paulburton@google.com> <20210701140754.5847a50f@oasis.local.home> <20210701142624.44bb4dde@oasis.local.home> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <51babd56c2fe53ba011152700a546151@perches.com> X-Sender: joe@perches.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout01 X-Rspamd-Queue-Id: 6CD962448B8 X-Stat-Signature: 8b1988hbxa8dkbeondchxrn7teat51ri X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19G+PKuYMGNpgor/GEopWJcjhvhoKlY1NU= X-HE-Tag: 1625168130-156347 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-01 11:26, Steven Rostedt wrote: > [ Added Joe Perches ] > > On Thu, 1 Jul 2021 11:12:54 -0700 > Paul Burton wrote: > >> > not to mention, we don't >> > use '//' comments in the kernel, so that would have to be changed. >> >> D'oh! Apparently a year away from the kernel melted my internal style >> checker. Interestingly though, checkpatch didn't complain about this >> as >> I would have expected... > > Joe, should the above be added to checkpatch? > > I do understand that there are a few cases it's acceptable. Like for > SPDX headers. C99 comments are allowed since about 5 years ago. And if you really want there's a checkpatch option to disable them. https://lore.kernel.org/patchwork/patch/1031132/