From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: yocto@yoctoproject.org
Subject: Re: [npm] duplicate code
Date: Fri, 4 Oct 2019 08:53:10 +0200 [thread overview]
Message-ID: <51c5973e-2c1a-f212-f963-9a2b321f480d@herbrechtsmeier.net> (raw)
In-Reply-To: <1078346093.8578188.1570117048745.JavaMail.zimbra@savoirfairelinux.com>
Hi Jean-Marie,
what work do you plan to do on npm and recipetool?
I have start to rework the complete npm integration to synchronize it
with other languages like python. I replace the bitbake npm fetch with
the wget fetcher and download the npm tgz files direct. The idea is to
handle every package as a separate recipe and move the package
dependencies into the recipes. Therefore I parse the package.json and
the npm server json to create a recipe.
Regards
Stefan
Am 03.10.19 um 17:37 schrieb Jean-marie Lemetayer:
> Hi all,
>
> I am planning to do some work on npm and recipetool.
>
> I have seen that there is some duplicate code between bitbake/lib/bb/fetch2/npm.py and scripts/lib/recipetool/create_npm.py but there is some inconsistencies.
>
> Here is an example, the _parse_view() function which I patched recently has differ:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/bitbake/lib/bb/fetch2/npm.py#n157
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/scripts/lib/recipetool/create_npm.py#n244
>
> I think merging this "npm utility functions" is a good idea. But where ?
>
> I think about creating a new file: bitbake/lib/bb/npm_utils.py
>
> Or maybe use the existing bitbake/lib/bb/utils.py ?
>
> What do you think ?
>
>
> Jean-Marie LEMETAYER
> Enthusiast embedded systems engineer
> Savoir-faire Linux
>
next prev parent reply other threads:[~2019-10-04 7:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 15:37 [npm] duplicate code Jean-marie Lemetayer
2019-10-04 6:53 ` Stefan Herbrechtsmeier [this message]
2019-10-04 12:37 ` Jean-marie Lemetayer
2019-10-04 14:55 ` Stefan Herbrechtsmeier
2019-10-07 12:16 ` Jean-marie Lemetayer
2019-10-07 19:33 ` Stefan Herbrechtsmeier
2019-10-08 5:12 ` Josef Holzmayr
2019-10-08 20:04 ` Stefan Herbrechtsmeier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51c5973e-2c1a-f212-f963-9a2b321f480d@herbrechtsmeier.net \
--to=stefan@herbrechtsmeier.net \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.