From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y.patch added to -mm tree Date: Thu, 27 Jun 2013 14:39:25 -0700 Message-ID: <51ccb10d.HKsRM7oPY/Vj9I9Z%akpm@linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39000 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569Ab3F0Vj0 (ORCPT ); Thu, 27 Jun 2013 17:39:26 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org, fengguang.wu@intel.com, sjenning@linux.vnet.ibm.com Subject: + zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y.patch added to -mm tree To: sjenning@linux.vnet.ibm.com,fengguang.wu@intel.com From: akpm@linux-foundation.org Date: Thu, 27 Jun 2013 14:39:25 -0700 The patch titled Subject: zswap: fix Kconfig to depend on CRYPTO=y has been added to the -mm tree. Its filename is zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Seth Jennings Subject: zswap: fix Kconfig to depend on CRYPTO=y The Kconfig entry for zswap currently allows CRYPTO=m to satisfy the zswap dependency. However zswap is boolean (i.e. built-in) and has symbol dependencies on CRYPTO. Additionally, because the CRYPTO dependency is satisfied with =m, the additional selects zswap does can also be satisfied with =m, which leads to additional linking errors. >From the report: ===== tree: git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git since-3.9 head: 57cefddb141d6c9d0ab4f5a8589dd017f796a3f7 commit: 563f51c95b552e0d663df5bdf6cfc8e8a72d3ec6 [494/499] zswap: add to mm/ config: x86_64-randconfig-x004-0619 (attached as .config) All error/warnings: mm/built-in.o: In function `zswap_frontswap_invalidate_area': >> zswap.c:(.text+0x3a705): undefined reference to `zbud_free' mm/built-in.o: In function `zswap_free_entry': >> zswap.c:(.text+0x3a76b): undefined reference to `zbud_free' >> zswap.c:(.text+0x3a789): undefined reference to `zbud_get_pool_size' on and on... ===== This patch makes CRYPTO a built-in dependency of ZSWAP. This has the side effect of also making the selects built-in. Signed-off-by: Seth Jennings Reported-by: Fengguang Wu Signed-off-by: Andrew Morton --- mm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN mm/Kconfig~zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y mm/Kconfig --- a/mm/Kconfig~zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y +++ a/mm/Kconfig @@ -490,7 +490,7 @@ config ZBUD config ZSWAP bool "Compressed cache for swap pages (EXPERIMENTAL)" - depends on FRONTSWAP && CRYPTO + depends on FRONTSWAP && CRYPTO=y select CRYPTO_LZO select ZBUD default n _ Patches currently in -mm which might be from sjenning@linux.vnet.ibm.com are linux-next.patch mm-remove-compressed-copy-from-zram-in-memory.patch mm-remove-compressed-copy-from-zram-in-memory-fix.patch mm-remove-compressed-copy-from-zram-in-memory-fix-2.patch mm-remove-compressed-copy-from-zram-in-memory-fix-2-fix.patch zbud-add-to-mm.patch zbud-add-to-mm-init-under_reclaim.patch zswap-add-to-mm.patch zswap-add-to-mm-fix-kconfig-to-depend-on-crypto=y.patch zswap-add-documentation.patch maintainers-add-zswap-and-zbud-maintainer.patch