From mboxrd@z Thu Jan  1 00:00:00 1970
Subject: Re: [PATCH 4/6] cobalt/posix/mqueue: Export created mqueues to procfs
References: <20210823150031.78791-1-florian.bezdeka@siemens.com>
 <20210823150031.78791-5-florian.bezdeka@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <51d76bc9-e476-1f5b-2e96-075bb0d7c975@siemens.com>
Date: Tue, 24 Aug 2021 07:48:26 +0200
MIME-Version: 1.0
In-Reply-To: <20210823150031.78791-5-florian.bezdeka@siemens.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
List-Id: Discussions about the Xenomai project <xenomai.xenomai.org>
List-Unsubscribe: <https://xenomai.org/mailman/options/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=unsubscribe>
List-Archive: <http://xenomai.org/pipermail/xenomai/>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-request@xenomai.org?subject=help>
List-Subscribe: <https://xenomai.org/mailman/listinfo/xenomai>,
 <mailto:xenomai-request@xenomai.org?subject=subscribe>
To: Florian Bezdeka <florian.bezdeka@siemens.com>, xenomai@xenomai.org

On 23.08.21 17:00, Florian Bezdeka wrote:
> Exporting created mqueues to /proc/xenomai/registry/posix/mqueue helps
> to identify resource leaks by making mqueues visible. The content of all
> created virtual files is empty. Removal of such files is not possible
> and reports "operation not supported".
> 
> Signed-off-by: Florian Bezdeka <florian.bezdeka@siemens.com>
> ---
>  kernel/cobalt/posix/mqueue.c | 38 +++++++++++++++++++++++++++++++++++-
>  1 file changed, 37 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/cobalt/posix/mqueue.c b/kernel/cobalt/posix/mqueue.c
> index ebe7cf7b0..72759e484 100644
> --- a/kernel/cobalt/posix/mqueue.c
> +++ b/kernel/cobalt/posix/mqueue.c
> @@ -87,6 +87,41 @@ static struct mq_attr default_attr = {
>  
>  static LIST_HEAD(cobalt_mqq);
>  
> +#ifdef CONFIG_XENO_OPT_VFILE
> +
> +extern struct xnptree posix_ptree;

kernel/cobalt/posix/internal.h

Jan

> +
> +static int mq_vfile_show(struct xnvfile_regular_iterator *it, void *data)
> +{
> +	return 0;
> +}
> +
> +static struct xnvfile_regular_ops mq_vfile_ops = {
> +	.show = mq_vfile_show,
> +};
> +
> +static struct xnpnode_regular __mq_pnode = {
> +	.node = {
> +		.dirname = "mqueue",
> +		.root = &posix_ptree,
> +		.ops = &xnregistry_vfreg_ops,
> +	},
> +	.vfile = {
> +		.ops = &mq_vfile_ops,
> +	},
> +};
> +
> +#else /* !CONFIG_XENO_OPT_VFILE */
> +
> +static struct xnpnode_link __mq_pnode = {
> +	.node = {
> +		.dirname = "mqueue",
> +	}
> +};
> +
> +#endif /* !CONFIG_XENO_OPT_VFILE */
> +
> +
>  static inline struct cobalt_msg *mq_msg_alloc(struct cobalt_mq *mq)
>  {
>  	if (list_empty(&mq->avail))
> @@ -352,7 +387,8 @@ static int mq_open(int uqd, const char *name, int oflags,
>  		}
>  
>  		xnlock_get_irqsave(&nklock, s);
> -		err = xnregistry_enter(mq->name, mq, &mq->handle, NULL);
> +		err = xnregistry_enter(mq->name, mq, &mq->handle,
> +				       &__mq_pnode.node);
>  		if (err < 0)
>  			--mq->refs;
>  		else
> 

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux