All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9()
Date: Thu, 7 Nov 2019 11:24:00 +0100	[thread overview]
Message-ID: <51e0ede5-d94f-737d-f280-831da9d76f15@denx.de> (raw)
In-Reply-To: <kcis.3AD9942B6AC04175ACA12CD24E044BAD@DHPLMX01>

On 07/11/19 11:16, Christoph Niedermaier wrote:
> From: Stefano Babic <sbabic@denx.de>
> Sent: Tuesday 5th November 2019 17:26
> 
> 
>> On 05/11/19 17:05, Anatolij Gustschin wrote:
>>> Hi Stefano, Christoph,
>>>
>>> On Tue, 5 Nov 2019 16:57:18 +0100
>>> Stefano Babic sbabic at denx.de wrote:
>>> ...
>>>>> -static inline u8 imx6_is_bmode_from_gpr9(void)
>>>>> +static inline u32 imx6_is_bmode_from_gpr9(void)
>>>>>  {
>>>>>  	return readl(&src_base->gpr10) & IMX6_SRC_GPR10_BMODE;
>>>>>  }
>>>>>   
>>>>
>>>> This is correct but it rather conflicts with another patch I already
>>>> applied. Could you rebase and repost ? Thanks !
>>>
>>> This function was removed by Claudius (see commit ID e01c8cfe5769)
>>
>> Yes, but this check just one bit.
>>
>>> since there are no users any more. 
>>
>> Oh yes, you're right !
>>
>>> No need to rebase/repost.
>  
> OK, the commit from Claudius solves my problem and my patch is therefore outdated.
> It's funny that the useless function has been around for more than two years and now we're both trying to fix it at almost the same time ;-)
> 

It is a common path: nothing for years or all together. It happens many
times ;-)

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2019-11-07 10:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07 10:16 [U-Boot] [PATCH] imx: sys_proto: Fixing function imx6_is_bmode_from_gpr9() Christoph Niedermaier
2019-11-07 10:24 ` Stefano Babic [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-10-14 12:27 Christoph Niedermaier
2019-11-05 15:57 ` Stefano Babic
2019-11-05 16:05   ` Anatolij Gustschin
2019-11-05 16:25     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51e0ede5-d94f-737d-f280-831da9d76f15@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.