From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Anderson Date: Mon, 3 Feb 2020 10:27:50 -0500 Subject: [PATCH 2/4] arm: Move asm/utils.h to log2.h In-Reply-To: References: <9b2bb704-e7ea-74ea-c854-60a44472b8ec@gmail.com> Message-ID: <51e31862-f11c-6be0-dc6e-4e0fac65f466@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/3/20 10:11 AM, Simon Glass wrote: > Hi Marek, > > On Mon, 3 Feb 2020 at 01:28, Marek Vasut wrote: >> How could this be reviewed if it's missing basic things, like a SoB line ? I added that in a reply to the original patch; again my apologies for missing it the first time around. > > I saw you requested that on another patch. Apart from that it looks OK to me. > > People should use patman :-) I usually add my signed-off-by lines with git rebase --sign, but I forgot to do that this time. Though reasonably the thing which should have reminded me was running checkpatch (which I also forgot to run). > Regards, > Simon >