All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
	qemu devel <qemu-devel@nongnu.org>,
	Jason Wang <jasowang@redhat.com>,
	Li Zhijian <lizhijian@cn.fujitsu.com>,
	qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net/filter-mirror: Fix mirror initial check typo
Date: Fri, 30 Sep 2016 09:49:01 -0500	[thread overview]
Message-ID: <51eb078a-7f10-fcdc-59f3-0aa5d4ca9c84@redhat.com> (raw)
In-Reply-To: <1475202478-20716-1-git-send-email-zhangchen.fnst@cn.fujitsu.com>

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On 09/29/2016 09:27 PM, Zhang Chen wrote:
> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
> ---
>  net/filter-mirror.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

Could also go through qemu-trivial (cc'd).

> diff --git a/net/filter-mirror.c b/net/filter-mirror.c
> index 35df374..0ee58d9 100644
> --- a/net/filter-mirror.c
> +++ b/net/filter-mirror.c
> @@ -198,7 +198,7 @@ static void filter_mirror_setup(NetFilterState *nf, Error **errp)
>      MirrorState *s = FILTER_MIRROR(nf);
>  
>      if (!s->outdev) {
> -        error_setg(errp, "filter filter mirror needs 'outdev' "
> +        error_setg(errp, "filter mirror needs 'outdev' "
>                     "property set");
>          return;
>      }
> @@ -315,7 +315,7 @@ filter_mirror_set_outdev(Object *obj, const char *value, Error **errp)
>      g_free(s->outdev);
>      s->outdev = g_strdup(value);
>      if (!s->outdev) {
> -        error_setg(errp, "filter filter mirror needs 'outdev' "
> +        error_setg(errp, "filter mirror needs 'outdev' "
>                     "property set");
>          return;
>      }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  reply	other threads:[~2016-09-30 14:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30  2:27 [Qemu-devel] [PATCH] net/filter-mirror: Fix mirror initial check typo Zhang Chen
2016-09-30 14:49 ` Eric Blake [this message]
2016-10-08  8:19 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51eb078a-7f10-fcdc-59f3-0aa5d4ca9c84@redhat.com \
    --to=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.