From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.pengutronix.de (unknown [IPv6:2001:6f8:1178:4:290:27ff:fe1d:cc33]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2849F2C00E7 for ; Wed, 7 Aug 2013 17:36:21 +1000 (EST) Message-ID: <5201F8C7.6090208@pengutronix.de> Date: Wed, 07 Aug 2013 09:35:35 +0200 From: Marc Kleine-Budde MIME-Version: 1.0 To: Gerhard Sittig Subject: Re: [PATCH v4 11/31] net: can: mscan: improve clock API use References: <1374495298-22019-1-git-send-email-gsi@denx.de> <1375821851-31609-1-git-send-email-gsi@denx.de> <1375821851-31609-12-git-send-email-gsi@denx.de> <5201F7A7.90906@pengutronix.de> In-Reply-To: <5201F7A7.90906@pengutronix.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7sHSwIO1Ifrq9IMPaF9Fe0dxaUw1NDlbs" Cc: devicetree@vger.kernel.org, Mike Turquette , Detlev Zundel , Wolfram Sang , David Woodhouse , Greg Kroah-Hartman , Rob Herring , Mark Brown , Wolfgang Grandegger , Anatolij Gustschin , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7sHSwIO1Ifrq9IMPaF9Fe0dxaUw1NDlbs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2013 09:30 AM, Marc Kleine-Budde wrote: > On 08/06/2013 10:43 PM, Gerhard Sittig wrote: >> the .get_clock() callback is run from probe() and might allocate >> resources, introduce a .put_clock() callback that is run from remove()= >> to undo any allocation activities >=20 > AFAICS With this patch put_clock() is still a no-op, is there a patch > which adds some code there? If not, please remove. I missed patch 27. sorry for the noise. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --7sHSwIO1Ifrq9IMPaF9Fe0dxaUw1NDlbs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iEYEARECAAYFAlIB+McACgkQjTAFq1RaXHPW1QCfQEN9n0CCVgeXBrmL1PXUr8nh B8IAnRX3qHUzH9byl6SSoA6D+JQpvGly =rOhq -----END PGP SIGNATURE----- --7sHSwIO1Ifrq9IMPaF9Fe0dxaUw1NDlbs-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: mkl@pengutronix.de (Marc Kleine-Budde) Date: Wed, 07 Aug 2013 09:35:35 +0200 Subject: [PATCH v4 11/31] net: can: mscan: improve clock API use In-Reply-To: <5201F7A7.90906@pengutronix.de> References: <1374495298-22019-1-git-send-email-gsi@denx.de> <1375821851-31609-1-git-send-email-gsi@denx.de> <1375821851-31609-12-git-send-email-gsi@denx.de> <5201F7A7.90906@pengutronix.de> Message-ID: <5201F8C7.6090208@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/07/2013 09:30 AM, Marc Kleine-Budde wrote: > On 08/06/2013 10:43 PM, Gerhard Sittig wrote: >> the .get_clock() callback is run from probe() and might allocate >> resources, introduce a .put_clock() callback that is run from remove() >> to undo any allocation activities > > AFAICS With this patch put_clock() is still a no-op, is there a patch > which adds some code there? If not, please remove. I missed patch 27. sorry for the noise. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 259 bytes Desc: OpenPGP digital signature URL: