All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: shmobile: lager: Add Display Unit support
Date: Wed, 07 Aug 2013 17:26:27 +0000	[thread overview]
Message-ID: <52028343.7010206@cogentembedded.com> (raw)
In-Reply-To: <1375892397-5822-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

On 08/07/2013 08:19 PM, Laurent Pinchart wrote:

> Only the VGA output is currently supported.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>   arch/arm/configs/lager_defconfig     |  2 ++
>   arch/arm/mach-shmobile/board-lager.c | 42 ++++++++++++++++++++++++++++++++++++
>   2 files changed, 44 insertions(+)

> diff --git a/arch/arm/configs/lager_defconfig b/arch/arm/configs/lager_defconfig
> index e777ef2..35bff5e 100644
> --- a/arch/arm/configs/lager_defconfig
> +++ b/arch/arm/configs/lager_defconfig
> @@ -89,6 +89,8 @@ CONFIG_THERMAL=y
>   CONFIG_RCAR_THERMAL=y
>   CONFIG_REGULATOR=y
>   CONFIG_REGULATOR_FIXED_VOLTAGE=y
> +CONFIG_DRM=y
> +CONFIG_DRM_RCAR_DU=y
>   # CONFIG_USB_SUPPORT is not set
>   CONFIG_MMC=y
>   CONFIG_MMC_SDHI=y

    Should be in a separate patch.

> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index 4872939..357f329 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
> @@ -28,6 +28,7 @@
>   #include <linux/mmc/sh_mmcif.h>
>   #include <linux/pinctrl/machine.h>
>   #include <linux/platform_data/gpio-rcar.h>
> +#include <linux/platform_data/rcar-du.h>
>   #include <linux/platform_device.h>
>   #include <linux/regulator/fixed.h>
>   #include <linux/regulator/machine.h>
> @@ -38,6 +39,38 @@
>   #include <asm/mach-types.h>
>   #include <asm/mach/arch.h>
>
[...]
> +static struct rcar_du_platform_data lager_du_pdata = {

    Should be annotated with '__initdata'.

> +	.encoders = lager_du_encoders,
> +	.num_encoders = ARRAY_SIZE(lager_du_encoders),
> +};
> +

WBR, Sergei


      reply	other threads:[~2013-08-07 17:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-07 16:19 [PATCH 5/5] ARM: shmobile: lager: Add Display Unit support Laurent Pinchart
2013-08-07 17:26 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52028343.7010206@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.