From: "Jürgen Groß" <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Julien Grall" <julien@xen.org>, "Wei Liu" <wl@xen.org>,
"Jan Beulich" <JBeulich@suse.com>,
"Daniel De Graaf" <dgdegra@tycho.nsa.gov>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH for-4.13 v4 1/3] xen/flask: Drop the gen-policy.py script
Date: Tue, 10 Dec 2019 13:41:55 +0100 [thread overview]
Message-ID: <5202e74a-81c2-8f08-384a-4a238bfbefe8@suse.com> (raw)
In-Reply-To: <20191210121701.8196-1-andrew.cooper3@citrix.com>
On 10.12.19 13:17, Andrew Cooper wrote:
> The script is Python 2 specific, and fails with string/binary issues with
> Python 3:
>
> Traceback (most recent call last):
> File "gen-policy.py", line 14, in <module>
> for char in sys.stdin.read():
> File "/usr/lib/python3.5/codecs.py", line 321, in decode
> (result, consumed) = self._buffer_decode(data, self.errors, final)
> UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8c in position 0: invalid start byte
>
> Fixing the script to be compatible isn't hard, but using python here is
> wasteful. Drop the script entirely, and write an equivelent flask-policy.S
> instead. This removes the need for a $(PYTHON) and $(CC) pass.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Release-acked-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-10 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-07 21:16 [Xen-devel] [PATCH for-4.13 v3 0/3] xen: Build fixes related to Python3 Andrew Cooper
2019-12-07 21:16 ` [Xen-devel] [PATCH v3 1/3] xen/flask: Drop the gen-policy.py script Andrew Cooper
2019-12-09 10:38 ` George Dunlap
2019-12-09 13:38 ` Jan Beulich
2019-12-09 17:01 ` Andrew Cooper
2019-12-10 7:58 ` Jan Beulich
2019-12-09 18:00 ` Daniel De Graaf
2019-12-10 12:17 ` [Xen-devel] [PATCH for-4.13 v4 " Andrew Cooper
2019-12-10 12:41 ` Jürgen Groß [this message]
2019-12-10 14:04 ` Jan Beulich
2019-12-10 15:29 ` Julien Grall
2019-12-07 21:16 ` [Xen-devel] [PATCH v3 2/3] xen/banner: Drop the fig-to-oct.py script Andrew Cooper
2019-12-09 11:06 ` George Dunlap
2019-12-07 21:16 ` [Xen-devel] [PATCH v3 3/3] xen/build: Automatically locate a suitable python interpreter Andrew Cooper
2019-12-09 11:00 ` George Dunlap
2019-12-10 12:45 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202e74a-81c2-8f08-384a-4a238bfbefe8@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.