All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: paulmck <paulmck@kernel.org>
Cc: zhouzhouyi@gmail.com, Josh Triplett <josh@joshtriplett.org>,
	rostedt <rostedt@goodmis.org>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	"Joel Fernandes, Google" <joel@joelfernandes.org>,
	rcu <rcu@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE
Date: Tue, 13 Jul 2021 09:09:04 -0400 (EDT)	[thread overview]
Message-ID: <520385500.15226.1626181744332.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20210713041607.GU4397@paulmck-ThinkPad-P17-Gen-1>

----- On Jul 13, 2021, at 12:16 AM, paulmck paulmck@kernel.org wrote:

> On Tue, Jul 13, 2021 at 08:56:45AM +0800, zhouzhouyi@gmail.com wrote:
>> From: Zhouyi Zhou <zhouzhouyi@gmail.com>
>> 
>> Hi Paul,
>> 
>> During my studying of RCU, I did a grep in the kernel source tree.
>> I found there are 3 places where the macro name CONFIG_TASKS_RCU_TRACE
>> should be CONFIG_TASKS_TRACE_RCU instead.
>> 
>> Without memory fencing, the idle/userspace task inspection may not
>> be so accurate.
>> 
>> Thanks for your constant encouragement for my studying.
>> 
>> Best Wishes
>> Zhouyi
>> 
>> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> 
> Good eyes, and those could cause real bugs, so thank you!

Hi Paul,

This makes me wonder: what is missing testing-wise in rcutorture to
catch those issues with testing before they reach mainline ?

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com

  parent reply	other threads:[~2021-07-13 13:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  0:56 [PATCH] RCU: Fix macro name CONFIG_TASKS_RCU_TRACE zhouzhouyi
2021-07-13  4:16 ` Paul E. McKenney
2021-07-13  6:16   ` Zhouyi Zhou
2021-07-13 13:09   ` Mathieu Desnoyers [this message]
2021-07-13 13:18     ` Paul E. McKenney
2021-07-13 15:19       ` Paul E. McKenney
2021-07-14  4:44         ` Zhouyi Zhou
2021-07-15  3:51           ` Paul E. McKenney
2021-07-15  8:45             ` Zhouyi Zhou
2021-07-15 18:09               ` Paul E. McKenney
2021-07-17 22:03                 ` Zhouyi Zhou
2021-07-18 21:08                   ` Paul E. McKenney
2021-07-20  1:39                     ` Randy Dunlap
2021-07-20  2:07                       ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520385500.15226.1626181744332.JavaMail.zimbra@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=jiangshanlai@gmail.com \
    --cc=joel@joelfernandes.org \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=zhouzhouyi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.