From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7tMs-0006Cx-5x for qemu-devel@nongnu.org; Fri, 09 Aug 2013 16:33:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V7tMj-00045A-5L for qemu-devel@nongnu.org; Fri, 09 Aug 2013 16:33:02 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:39805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V7tMj-00043f-0w for qemu-devel@nongnu.org; Fri, 09 Aug 2013 16:32:53 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 9 Aug 2013 16:32:49 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 908ACC90044 for ; Fri, 9 Aug 2013 16:32:44 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r79KWk88173606 for ; Fri, 9 Aug 2013 16:32:46 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r79KWj2L031045 for ; Fri, 9 Aug 2013 16:32:45 -0400 Message-ID: <520551ED.40907@linux.vnet.ibm.com> Date: Fri, 09 Aug 2013 16:32:45 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1376078746-24948-1-git-send-email-mrhines@linux.vnet.ibm.com> <1376078746-24948-7-git-send-email-mrhines@linux.vnet.ibm.com> <5205507E.7070705@redhat.com> In-Reply-To: <5205507E.7070705@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-1.6 6/6] rdma: remaining documentation fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: yamahata@private.email.ne.jp, aliguori@us.ibm.com, quintela@redhat.com, frank.yangjie@gmail.com, qemu-devel@nongnu.org, owasserm@redhat.com, mrhines@us.ibm.com, pbonzini@redhat.com On 08/09/2013 04:26 PM, Eric Blake wrote: > On 08/09/2013 02:05 PM, mrhines@linux.vnet.ibm.com wrote: >> From: "Michael R. Hines" >> >> Was missing 'setup-time' in some of the QMP documentation... >> >> Signed-off-by: Michael R. Hines >> --- >> qmp-commands.hx | 10 ++++++++++ >> 1 file changed, 10 insertions(+) > Reviewed-by: Eric Blake > >> @@ -2742,6 +2751,7 @@ Examples: >> "remaining":1053304, >> "transferred":3720, >> "total-time":12345, >> + "setup-time":12345, > Theoretically, if setup-time == total-time, then we are still in the > setup phase, right? The example might be more realistic if it uses a > smaller number for setup time. But at the end of the day, I don't > actually care enough to force a respin, when we are this close to the > 1.6 deadline and this deserves to be in 1.6. > Ooops - well, when I was reading the file - all the numbers seemed like place-holders, not realistic numbers. This documentation is kind of hard to maintain in the first place - something like this is more the job of a tool like 'virt-test' which could actually exercise QMP and dump the output during a test cycle in case the user actually wanted to see what the migration life cycle actually looks like. - Michael