From: Eric Blake <eblake@redhat.com>
To: "Michael R. Hines" <mrhines@linux.vnet.ibm.com>
Cc: yamahata@private.email.ne.jp, aliguori@us.ibm.com,
quintela@redhat.com, frank.yangjie@gmail.com,
qemu-devel@nongnu.org, owasserm@redhat.com, mrhines@us.ibm.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 for-1.6 6/6] rdma: remaining documentation fixes
Date: Fri, 09 Aug 2013 14:36:16 -0600 [thread overview]
Message-ID: <520552C0.3060606@redhat.com> (raw)
In-Reply-To: <520551ED.40907@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]
On 08/09/2013 02:32 PM, Michael R. Hines wrote:
>>> "total-time":12345,
>>> + "setup-time":12345,
>> Theoretically, if setup-time == total-time, then we are still in the
>> setup phase, right? The example might be more realistic if it uses a
>> smaller number for setup time. But at the end of the day, I don't
>> actually care enough to force a respin, when we are this close to the
>> 1.6 deadline and this deserves to be in 1.6.
>>
>
> Ooops - well, when I was reading the file - all the numbers seemed like
> place-holders, not realistic numbers.
Indeed, which is why I'm okay with no respin.
>
> This documentation is kind of hard to maintain in the first place -
> something like this is more the job of a tool like 'virt-test' which
> could actually exercise QMP and dump the output during a test cycle in
> case the user actually wanted to see what the migration life cycle
> actually looks like.
Yes, I'd love to have more of this file generated (why are we forced to
duplicate efforts into both the .json and the .hx files again?)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-09 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 20:05 [Qemu-devel] [PATCH v2 for-1.6 0/6] rdma: uh oh! IPv6 broken in linux - need workaround mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 1/6] rdma: use resp.len after validation in qemu_rdma_registration_stop mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 2/6] rdma: validate RDMAControlHeader::len mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 3/6] rdma: check if RDMAControlHeader::len match transferred byte mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 4/6] rdma: proper getaddrinfo() handling mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 5/6] rdma: IPv6 over Ethernet (RoCE) is broken in linux - workaround mrhines
2013-08-09 20:05 ` [Qemu-devel] [PATCH v2 for-1.6 6/6] rdma: remaining documentation fixes mrhines
2013-08-09 20:26 ` Eric Blake
2013-08-09 20:32 ` Michael R. Hines
2013-08-09 20:36 ` Eric Blake [this message]
2013-08-14 16:27 ` [Qemu-devel] [PATCH v2 for-1.6 0/6] rdma: uh oh! IPv6 broken in linux - need workaround Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520552C0.3060606@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=frank.yangjie@gmail.com \
--cc=mrhines@linux.vnet.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=yamahata@private.email.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.