From: Eric Sandeen <sandeen@redhat.com>
To: dsterba@suse.cz, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2 V2] btrfs-progs: mark static & remove unused from non-kernel code
Date: Fri, 09 Aug 2013 18:16:30 -0500 [thread overview]
Message-ID: <5205784E.7030705@redhat.com> (raw)
In-Reply-To: <20130809224854.GN5284@twin.jikos.cz>
On 8/9/13 5:48 PM, David Sterba wrote:
> On Fri, Aug 09, 2013 at 03:20:47PM -0500, Eric Sandeen wrote:
>> Mark many functions as static, and remove any resulting dead code.
>
> Thanks.
>
>> -struct btrfs_root *link_subvol(struct btrfs_root *root, const char *base,
>> - u64 root_objectid)
>> +static struct btrfs_root *
>> +link_subvol(struct btrfs_root *root, const char *base, u64 root_objectid)
>
> Please keep the function defintion style if possible. I've fixed that at
> commit time, no need to resend.
Ok, fair enough - so preferred is
<lots of type stuff> function(some args . . ,
. . . more args . . .,
. . . last args)
? sorry, old xfs habits die hard. ;)
-Eric
> david
>
next prev parent reply other threads:[~2013-08-09 23:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 1:01 [PATCH 0/2] btrfs-progs: more statics & removals Eric Sandeen
2013-08-07 1:03 ` [PATCH 1/2] btrfs-progs: mark static & remove unused from shared kernel code Eric Sandeen
2013-08-07 1:05 ` [PATCH 2/2] btrfs-progs: mark static & remove unused from non-kernel code Eric Sandeen
2013-08-07 3:49 ` Eric Sandeen
2013-08-07 7:54 ` Stefan Behrens
2013-08-07 15:17 ` Eric Sandeen
2013-08-09 14:10 ` David Sterba
2013-08-09 14:39 ` Stefan Behrens
2013-08-09 20:20 ` [PATCH 2/2 V2] " Eric Sandeen
2013-08-09 22:48 ` David Sterba
2013-08-09 23:16 ` Eric Sandeen [this message]
2013-08-09 23:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5205784E.7030705@redhat.com \
--to=sandeen@redhat.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.