From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: marcel.a@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization
Date: Tue, 13 Aug 2013 16:54:56 +0200 [thread overview]
Message-ID: <520A48C0.5000205@redhat.com> (raw)
In-Reply-To: <87a9klllyz.fsf@codemonkey.ws>
Il 13/08/2013 16:11, Anthony Liguori ha scritto:
>> > Fix this up, clean up a trivial code duplication
>> > and add a comment explaining why we special-case 1.5
>> > with respect to pvpanic.
>> >
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Thanks for catching this. I'm a little disturbed by this. I use git-am
> --3way specifically to avoid problems from fuzzing but I guess merge
> artifacts are possible.
>
I wonder if we shouldn't disable pvpanic in 1.5 too, one-off behavior is
ugly and likely no one will notice.
Paolo
next prev parent reply other threads:[~2013-08-13 14:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 12:53 [Qemu-devel] [PATCH for-1.6] pc: fix up pc initialization Michael S. Tsirkin
2013-08-13 13:28 ` Eric Blake
2013-08-13 14:11 ` Anthony Liguori
2013-08-13 14:54 ` Paolo Bonzini [this message]
2013-08-13 15:11 ` Andreas Färber
2013-08-13 15:18 ` Michael S. Tsirkin
2013-08-13 15:27 ` Paolo Bonzini
2013-08-13 15:57 ` Andreas Färber
2013-08-13 16:12 ` Anthony Liguori
2013-08-18 14:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520A48C0.5000205@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.